blimp/client/core/contents/blimp_navigation_controller_impl_unittest.cc - Issue 2233023002: Adding BlimpNavigationController to Tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/contents/blimp_navigation_controller_impl_unittest.cc

Issue 2233023002: Adding BlimpNavigationController to Tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@nav_handler_remove

Patch Set: Fixing unit tests Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « blimp/client/core/contents/blimp_navigation_controller_impl.cc ('k') | blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/contents/blimp_navigation_controller_impl_unittest.cc

diff --git a/blimp/client/core/contents/blimp_navigation_controller_impl_unittest.cc b/blimp/client/core/contents/blimp_navigation_controller_impl_unittest.cc

index 02fc86aeb35d880dae5e119dbce4a3aa05818f7f..639415b20db6dcd2f7984cc718dcb7265a85695d 100644

--- a/blimp/client/core/contents/blimp_navigation_controller_impl_unittest.cc

+++ b/blimp/client/core/contents/blimp_navigation_controller_impl_unittest.cc

@@ -40,6 +40,7 @@ TEST(BlimpNavigationControllerImplTest, BackForwardNavigation) {

EXPECT_CALL(delegate, OnNavigationStateChanged());

navigation_controller.LoadURL(kExampleURL);

+ loop.RunUntilIdle();

EXPECT_EQ(kExampleURL, navigation_controller.GetURL());

EXPECT_CALL(feature, GoBack(_));