Issue 2233003002: Remove the GLES2_USE_MOJO macro.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2233003002: Remove the GLES2_USE_MOJO macro. (Closed)

Created:
4 years, 4 months ago by viettrungluu

Modified:
4 years, 4 months ago

Reviewers:
jamesr

CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, darin (slow to review), gregsimon, mojo-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+mojopublicwatch_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Remove the GLES2_USE_MOJO macro. People shouldn't include stuff from mojo/public/c/gpu for other purposes. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/9cd4702c45ff3da0f6105fa6f4fd109a49de173e

Patch Set 1 #

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -11 lines)			Patch
	M	mojo/public/c/gpu/BUILD.gn	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	mojo/public/c/gpu/GLES2/gl2mojo_internal.h	View		1 chunk	+0 lines, -10 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jamesr

lgtm, although this thingy only exists in order to make it easier to coexist with ...

4 years, 4 months ago (2016-08-10 17:47:58 UTC) #2

viettrungluu

4 years, 4 months ago (2016-08-10 17:50:26 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
9cd4702c45ff3da0f6105fa6f4fd109a49de173e (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages