Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 2232943003: Partially revert 8b0cda7f8d3f9a4f1d53c78600fb0c62c7eec7f9. (Closed)

Created:
4 years, 4 months ago by Robert Sesek
Modified:
4 years, 4 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Partially revert 8b0cda7f8d3f9a4f1d53c78600fb0c62c7eec7f9. That CL modified the conditions under which enable_dsyms and enable_stripping get set, which is not desired. This leaves in place the change for sanitizers. BUG=635242 R=dpranke@chromium.org Committed: https://crrev.com/002fbfa1c30058690e76c010d1b0b8801e8a2d39 Cr-Commit-Position: refs/heads/master@{#411306}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/config/mac/symbols.gni View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Robert Sesek
4 years, 4 months ago (2016-08-10 23:09:49 UTC) #2
Dirk Pranke
lgtm
4 years, 4 months ago (2016-08-10 23:29:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2232943003/1
4 years, 4 months ago (2016-08-11 12:10:13 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 12:13:48 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 12:15:25 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/002fbfa1c30058690e76c010d1b0b8801e8a2d39
Cr-Commit-Position: refs/heads/master@{#411306}

Powered by Google App Engine
This is Rietveld 408576698