build/config/mac/symbols.gni - Issue 2232943003: Partially revert 8b0cda7f8d3f9a4f1d53c78600fb0c62c7eec7f9.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/mac/symbols.gni

Issue 2232943003: Partially revert 8b0cda7f8d3f9a4f1d53c78600fb0c62c7eec7f9. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/config/mac/symbols.gni

diff --git a/build/config/mac/symbols.gni b/build/config/mac/symbols.gni

index 2cb0b8f02354ae9c4d66247f72248502a8916124..6166b123d1ba953a4d3b36db95fe85294f32feaa 100644

--- a/build/config/mac/symbols.gni

+++ b/build/config/mac/symbols.gni

@@ -14,14 +14,14 @@ declare_args() {

# the //build/toolchain/mac/linker_driver.py. Enabling this will result in

# all shared library, loadable module, and executable targets having a dSYM

# generated.

- enable_dsyms = (is_official_build && is_chrome_branded) || using_sanitizer

+ enable_dsyms = is_official_build || using_sanitizer

# Strip symbols from linked targets by default. If this is enabled, the

# //build/config/mac:strip_all config will be applied to all linked targets.

# If custom stripping parameters are required, remove that config from a

# linked target and apply custom -Wcrl,strip flags. See

# //build/toolchain/mac/linker_driver.py for more information.

- enable_stripping = is_official_build && is_chrome_branded

+ enable_stripping = is_official_build

}

# Save unstripped copies of targets with a ".unstripped" suffix. This is

« no previous file with comments | « no previous file | no next file » | no next file with comments »