chrome/android/java/res/layout/password_entry_editor_interactive.xml - Issue 2232893002: Display text prompting user to set screen lock in order to view password in PasswordEntryEditor

Unified Diff: chrome/android/java/res/layout/password_entry_editor_interactive.xml

Issue 2232893002: Display text prompting user to set screen lock in order to view password in PasswordEntryEditor Base URL: https://chromium.googlesource.com/chromium/src.git@reauthentication

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java » ('j') | chrome/android/java/strings/android_chrome_strings.grd » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/res/layout/password_entry_editor_interactive.xml

diff --git a/chrome/android/java/res/layout/password_entry_editor_interactive.xml b/chrome/android/java/res/layout/password_entry_editor_interactive.xml

index ef69ef249e07f59aa273e03e48495099e8e68c91..3529b53ea582c6c0cd82a075c0128baaa9b97f52 100644

--- a/chrome/android/java/res/layout/password_entry_editor_interactive.xml

+++ b/chrome/android/java/res/layout/password_entry_editor_interactive.xml

@@ -111,7 +111,19 @@

android:gravity="center_vertical"

android:textAppearance="?android:attr/textAppearanceMedium" />

+ <TextView

+ android:id="@+id/password_entry_editor_set_device_lock"

+ android:text="@string/password_entry_editor_set_device_lock_prompt"

+ android:textColor="@color/default_text_color"

+ android:layout_width="match_parent"

+ android:layout_height="match_parent"

+ android:layout_marginTop="10dp"

+ android:layout_marginStart="15dp"

Theresa 2016/08/12 18:34:28 This TextView and password_entry_editor_password s

dozsa 2016/08/18 12:40:37 Done.

+ android:textAppearance="?android:attr/textAppearanceMedium"

+ android:visibility="gone" />

<LinearLayout

+ android:id="@+id/password_entry_editor_display_password"

android:layout_width="wrap_content"

android:layout_height="wrap_content"

android:orientation="horizontal">

@@ -119,14 +131,15 @@

<TextView

android:id="@+id/password_entry_editor_password"

android:textColor="@color/default_text_color"

- android:layout_width="fill_parent"

- android:layout_height="wrap_content"

+ android:layout_width="match_parent"

+ android:layout_height="match_parent"

android:layout_marginTop="10dp"

android:layout_marginStart="15dp"

android:inputType="textPassword"

- android:textAppearance="?android:attr/textAppearanceMedium" />

+ android:textAppearance="?android:attr/textAppearanceMedium"/>

Theresa 2016/08/12 18:34:28 nit: add the space back before the />

dozsa 2016/08/18 12:40:37 Done.

<View

+ android:id="@+id/password_entry_editor_spacer"

Theresa 2016/08/12 18:34:28 It doesn't look like this id is used anywhere.

dozsa 2016/08/18 12:40:37 True, I've removed it.

android:layout_width="0dp"

android:layout_height="0dp"

android:layout_weight="1" />