Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 2232863004: Create new error message for missing generated files (Closed)

Created:
4 years, 4 months ago by Brian Wilkerson
Modified:
4 years, 4 months ago
Reviewers:
skybrian, scheglov
CC:
reviews_dartlang.org, skybrian
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -7 lines) Patch
M pkg/analysis_server/lib/src/services/correction/fix.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/fix_internal.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/services/correction/organize_directives.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 2 chunks +15 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +32 lines, -2 lines 2 comments Download
M pkg/analyzer/test/src/task/dart_test.dart View 4 chunks +18 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
Brian Wilkerson
4 years, 4 months ago (2016-08-10 18:43:45 UTC) #2
skybrian
lgtm LGTM
4 years, 4 months ago (2016-08-10 19:06:39 UTC) #4
scheglov
LGTM https://codereview.chromium.org/2232863004/diff/1/pkg/analyzer/lib/src/task/dart.dart File pkg/analyzer/lib/src/task/dart.dart (right): https://codereview.chromium.org/2232863004/diff/1/pkg/analyzer/lib/src/task/dart.dart#newcode6463 pkg/analyzer/lib/src/task/dart.dart:6463: List<String> suffixes = <String>[ const const
4 years, 4 months ago (2016-08-10 19:12:15 UTC) #5
Brian Wilkerson
https://codereview.chromium.org/2232863004/diff/1/pkg/analyzer/lib/src/task/dart.dart File pkg/analyzer/lib/src/task/dart.dart (right): https://codereview.chromium.org/2232863004/diff/1/pkg/analyzer/lib/src/task/dart.dart#newcode6463 pkg/analyzer/lib/src/task/dart.dart:6463: List<String> suffixes = <String>[ Done
4 years, 4 months ago (2016-08-10 19:42:02 UTC) #6
Brian Wilkerson
4 years, 4 months ago (2016-08-10 19:42:18 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2657536034df466e7a71022a32d72ab32a4d48d0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698