pkg/analysis_server/lib/src/services/correction/organize_directives.dart - Issue 2232863004: Create new error message for missing generated files

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/analysis_server/lib/src/services/correction/organize_directives.dart

Issue 2232863004: Create new error message for missing generated files (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/analysis_server/lib/src/services/correction/fix_internal.dart ('k') | pkg/analyzer/lib/src/generated/error.dart » ('j') | pkg/analyzer/lib/src/task/dart.dart » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/analysis_server/lib/src/services/correction/organize_directives.dart

diff --git a/pkg/analysis_server/lib/src/services/correction/organize_directives.dart b/pkg/analysis_server/lib/src/services/correction/organize_directives.dart

index 0d355668c424ff8fef5bdb953be6f67776ebf2ad..56d4bb092665c3edfd5c84dd39d68d535d058e31 100644

--- a/pkg/analysis_server/lib/src/services/correction/organize_directives.dart

+++ b/pkg/analysis_server/lib/src/services/correction/organize_directives.dart

@@ -47,7 +47,9 @@ class DirectiveOrganizer {

bool _isUnresolvedUri(UriBasedDirective directive) {

for (AnalysisError error in errors) {

- if (error.errorCode == CompileTimeErrorCode.URI_DOES_NOT_EXIST &&

+ ErrorCode errorCode = error.errorCode;

+ if ((errorCode == CompileTimeErrorCode.URI_DOES_NOT_EXIST ||

+ errorCode == CompileTimeErrorCode.URI_HAS_NOT_BEEN_GENERATED) &&

directive.uri.offset == error.offset) {

return true;

}