components/omnibox/browser/zero_suggest_provider_unittest.cc - Issue 2232863002: Remove search::GetSearchTerms since it always returns empty string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/zero_suggest_provider_unittest.cc

Issue 2232863002: Remove search::GetSearchTerms since it always returns empty string (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_query_extract

Patch Set: Android Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/omnibox/browser/omnibox_field_trial_unittest.cc ('k') | components/sessions/core/serialized_navigation_entry.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/omnibox/browser/zero_suggest_provider_unittest.cc

diff --git a/components/omnibox/browser/zero_suggest_provider_unittest.cc b/components/omnibox/browser/zero_suggest_provider_unittest.cc

index 84f2d7160bf7e7c7b9f89970cbc10ee9cddcea6a..7d411e4227c6dbc245f39ab3cdfd122d3241fd00 100644

--- a/components/omnibox/browser/zero_suggest_provider_unittest.cc

+++ b/components/omnibox/browser/zero_suggest_provider_unittest.cc

@@ -328,8 +328,8 @@ TEST_F(ZeroSuggestProviderTest, TestMostVisitedNavigateToSearchPage) {

std::string search_url("https://www.google.com/?q=flowers");

AutocompleteInput srp_input(

base::ASCIIToUTF16(search_url), base::string16::npos, std::string(),

- GURL(search_url), metrics::OmniboxEventProto::

- SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT,

+ GURL(search_url),

+ metrics::OmniboxEventProto::SEARCH_RESULT_PAGE_NO_SEARCH_TERM_REPLACEMENT,

false, false, true, true, true, TestSchemeClassifier());

provider_->Start(srp_input, false);