components/omnibox/browser/omnibox_field_trial_unittest.cc - Issue 2232863002: Remove search::GetSearchTerms since it always returns empty string

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/omnibox_field_trial_unittest.cc

Issue 2232863002: Remove search::GetSearchTerms since it always returns empty string (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_query_extract

Patch Set: Android Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/omnibox/browser/omnibox_edit_unittest.cc ('k') | components/omnibox/browser/zero_suggest_provider_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/omnibox/browser/omnibox_field_trial_unittest.cc

diff --git a/components/omnibox/browser/omnibox_field_trial_unittest.cc b/components/omnibox/browser/omnibox_field_trial_unittest.cc

index 8ceeb08dd1a5cf5a7a126970566cc42954eb00d5..7e3577359a832c12cdf86856bebcadfcc8a9a78e 100644

--- a/components/omnibox/browser/omnibox_field_trial_unittest.cc

+++ b/components/omnibox/browser/omnibox_field_trial_unittest.cc

@@ -363,10 +363,6 @@ TEST_F(OmniboxFieldTrialTest, GetValueForRuleInContext) {

OmniboxEventProto::HOME_PAGE); // exact match

ExpectRuleValue("rule1-4-*-value",

"rule1", OmniboxEventProto::OTHER); // partial fallback

- ExpectRuleValue("rule1-*-*-value",

- "rule1",

- OmniboxEventProto:: // fallback to global

- SEARCH_RESULT_PAGE_DOING_SEARCH_TERM_REPLACEMENT);

// Tests for rule 2.

ExpectRuleValue("rule2-*-0-value",

"rule2",