Remove search::GetSearchTerms since it always returns empty string

chrome/browser/ui/search/search_tab_helper.cc

Index: chrome/browser/ui/search/search_tab_helper.cc
diff --git a/chrome/browser/ui/search/search_tab_helper.cc b/chrome/browser/ui/search/search_tab_helper.cc
index d962d6296e3249686cef37ada18411f9f99b49b3..140206394f86f78794dabedacdf56ace5075dd83 100644
--- a/chrome/browser/ui/search/search_tab_helper.cc
+++ b/chrome/browser/ui/search/search_tab_helper.cc
@@ -74,10 +74,6 @@ bool IsNTP(const content::WebContents* contents) {
   return search::IsInstantNTP(contents);
 }
 
-bool IsSearchResults(const content::WebContents* contents) {
-  return !search::GetSearchTerms(contents).empty();
-}
-
 bool IsLocal(const content::WebContents* contents) {
   if (!contents)
     return false;
@@ -476,9 +472,6 @@ void SearchTabHelper::UpdateMode(bool update_origin) {
   if (IsNTP(web_contents_)) {
     type = SearchMode::MODE_NTP;
     origin = SearchMode::ORIGIN_NTP;
-  } else if (IsSearchResults(web_contents_)) {
-    type = SearchMode::MODE_SEARCH_RESULTS;
-    origin = SearchMode::ORIGIN_SEARCH;

[Peter Kasting, 2016/08/13 05:03:44]

This is the only non-unittest location that sets this mode or this origin, so
these values should be removed, along with anything that references them.

[Marc Treib, 2016/08/16 12:00:17]

Yup, on my list :)
I've added TODOs to the definitions.

   }
   if (!update_origin)
     origin = model_.mode().origin;