Remove search::GetSearchTerms since it always returns empty string

chrome/browser/ui/search/search_tab_helper.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/search/search_tab_helper.h"
 
 #include <memory>
 #include <set>
 
 #include "base/memory/ptr_util.h"
@@ skipping 56 matching lines @@
   // We can't use WebContents::GetURL() because that uses the active entry,
   // whereas we want the visible entry.
   const content::NavigationEntry* entry =
       contents->GetController().GetVisibleEntry();
   if (entry && entry->GetVirtualURL() == GURL(chrome::kChromeUINewTabURL))
     return true;
 
   return search::IsInstantNTP(contents);
 }
 
-bool IsSearchResults(const content::WebContents* contents) {
-  return !search::GetSearchTerms(contents).empty();
-}
-
 bool IsLocal(const content::WebContents* contents) {
   if (!contents)
     return false;
   const content::NavigationEntry* entry =
       contents->GetController().GetVisibleEntry();
   return entry && entry->GetURL() == GURL(chrome::kChromeSearchLocalNtpUrl);
 }
 
 // Returns true if |contents| are rendered inside an Instant process.
 bool InInstantProcess(Profile* profile,
@@ skipping 378 matching lines @@
       delegate_->OnWebContentsInstantSupportDisabled(web_contents_);
   }
 }
 
 void SearchTabHelper::UpdateMode(bool update_origin) {
   SearchMode::Type type = SearchMode::MODE_DEFAULT;
   SearchMode::Origin origin = SearchMode::ORIGIN_DEFAULT;
   if (IsNTP(web_contents_)) {
     type = SearchMode::MODE_NTP;
     origin = SearchMode::ORIGIN_NTP;
-  } else if (IsSearchResults(web_contents_)) {
-    type = SearchMode::MODE_SEARCH_RESULTS;
-    origin = SearchMode::ORIGIN_SEARCH;

[Peter Kasting, 2016/08/13 05:03:44]

This is the only non-unittest location that sets this mode or this origin, so
these values should be removed, along with anything that references them.

[Marc Treib, 2016/08/16 12:00:17]

Yup, on my list :)
I've added TODOs to the definitions.

   }
   if (!update_origin)
     origin = model_.mode().origin;
 
   OmniboxView* omnibox = GetOmniboxView();
   if (omnibox && omnibox->model()->user_input_in_progress())
     type = SearchMode::MODE_SEARCH_SUGGESTIONS;
 
   SearchMode old_mode(model_.mode());
   model_.SetMode(SearchMode(type, origin));
@@ skipping 23 matching lines @@
 
 bool SearchTabHelper::IsInputInProgress() const {
   OmniboxView* omnibox = GetOmniboxView();
   return !model_.mode().is_ntp() && omnibox &&
       omnibox->model()->focus_state() == OMNIBOX_FOCUS_VISIBLE;
 }
 
 OmniboxView* SearchTabHelper::GetOmniboxView() const {
   return delegate_ ? delegate_->GetOmniboxView() : NULL;
 }