Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1667)

Unified Diff: chrome/browser/search/search.h

Issue 2232863002: Remove search::GetSearchTerms since it always returns empty string (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@remove_query_extract
Patch Set: Mac Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/search/search.cc » ('j') | chrome/browser/search/search.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/search/search.h
diff --git a/chrome/browser/search/search.h b/chrome/browser/search/search.h
index b32da509da92f7af78201fb0927a042239c1695d..d477efb079bd1d9db578f9669646bba82d872f5e 100644
--- a/chrome/browser/search/search.h
+++ b/chrome/browser/search/search.h
@@ -40,8 +40,7 @@ enum CacheableNTPLoad {
bool IsSuggestPrefEnabled(Profile* profile);
// Extracts and returns search terms from |url|. Does not consider Instant
-// support state of the page and does not check for a privileged process, so
-// most callers should use GetSearchTerms() below instead.
+// support state of the page and does not check for a privileged process.
Peter Kasting 2016/08/13 05:03:44 I suspect you don't even need the second sentence,
Marc Treib 2016/08/16 12:00:17 Fair enough, removed.
base::string16 ExtractSearchTermsFromURL(Profile* profile, const GURL& url);
// Returns true if it is okay to extract search terms from |url|. |url| must
@@ -49,21 +48,6 @@ base::string16 ExtractSearchTermsFromURL(Profile* profile, const GURL& url);
// the default search provider.
bool IsQueryExtractionAllowedForURL(Profile* profile, const GURL& url);
-// Returns the search terms attached to a specific NavigationEntry, or empty
-// string otherwise. Does not check Instant support, so most callers should use
-// GetSearchTerms() below instead.
-base::string16 GetSearchTermsFromNavigationEntry(
- const content::NavigationEntry* entry);
-
-// Returns search terms if this WebContents is a search results page. It looks
-// in the visible NavigationEntry first, to see if search terms have already
-// been extracted. Failing that, it tries to extract search terms from the URL.
-//
-// Returns a blank string if search terms were not found, or if search terms
-// extraction is disabled for this WebContents or profile, or if |contents|
-// does not support Instant.
-base::string16 GetSearchTerms(const content::WebContents* contents);
-
// Returns true if |url| should be rendered in the Instant renderer process.
bool ShouldAssignURLToInstantRenderer(const GURL& url, Profile* profile);
« no previous file with comments | « no previous file | chrome/browser/search/search.cc » ('j') | chrome/browser/search/search.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698