Remove search::GetSearchTerms since it always returns empty string

chrome/browser/search/search.h

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SEARCH_SEARCH_H_
 #define CHROME_BROWSER_SEARCH_SEARCH_H_
 
 #include <string>
 #include <utility>
 #include <vector>
@@ skipping 22 matching lines @@
 enum CacheableNTPLoad {
   CACHEABLE_NTP_LOAD_FAILED = 0,
   CACHEABLE_NTP_LOAD_SUCCEEDED = 1,
   CACHEABLE_NTP_LOAD_MAX = 2
 };
 
 // Returns whether the suggest is enabled for the given |profile|.
 bool IsSuggestPrefEnabled(Profile* profile);
 
 // Extracts and returns search terms from |url|. Does not consider Instant
-// support state of the page and does not check for a privileged process, so
-// most callers should use GetSearchTerms() below instead.
+// support state of the page and does not check for a privileged process.

[Peter Kasting, 2016/08/13 05:03:44]

I suspect you don't even need the second sentence, since those concepts aren't
really meaningful anymore for anything to have distinct behavior.

[Marc Treib, 2016/08/16 12:00:17]

Fair enough, removed.

 base::string16 ExtractSearchTermsFromURL(Profile* profile, const GURL& url);
 
 // Returns true if it is okay to extract search terms from |url|. |url| must
 // have a secure scheme and must contain the search terms replacement key for
 // the default search provider.
 bool IsQueryExtractionAllowedForURL(Profile* profile, const GURL& url);
 
-// Returns the search terms attached to a specific NavigationEntry, or empty
-// string otherwise. Does not check Instant support, so most callers should use
-// GetSearchTerms() below instead.
-base::string16 GetSearchTermsFromNavigationEntry(
-    const content::NavigationEntry* entry);
-
-// Returns search terms if this WebContents is a search results page. It looks
-// in the visible NavigationEntry first, to see if search terms have already
-// been extracted. Failing that, it tries to extract search terms from the URL.
-//
-// Returns a blank string if search terms were not found, or if search terms
-// extraction is disabled for this WebContents or profile, or if |contents|
-// does not support Instant.
-base::string16 GetSearchTerms(const content::WebContents* contents);
-
 // Returns true if |url| should be rendered in the Instant renderer process.
 bool ShouldAssignURLToInstantRenderer(const GURL& url, Profile* profile);
 
 // Returns true if |contents| is rendered inside the Instant process for
 // |profile|.
 bool IsRenderedInInstantProcess(const content::WebContents* contents,
                                 Profile* profile);
 
 // Returns true if the Instant |url| should use process per site.
 bool ShouldUseProcessPerSiteForInstantURL(const GURL& url, Profile* profile);
@@ skipping 94 matching lines @@
 
 // Returns true if 'use_search_path_for_instant' flag is set to true in field
 // trials to use an '/search' path in an alternate Instant search base page URL
 // for prefetching search results. This allows experimentation of Instant
 // search.
 bool ShouldUseSearchPathForInstant();
 
 }  // namespace search
 
 #endif  // CHROME_BROWSER_SEARCH_SEARCH_H_