Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Unified Diff: scripts/slave/recipe_modules/goma/example.expected/win_upload_logs.json

Issue 2232733002: Add test for upload_logs() in recipe_modules/goma (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@goma_logs
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: scripts/slave/recipe_modules/goma/example.expected/win_upload_logs.json
diff --git a/scripts/slave/recipe_modules/goma/example.expected/win.json b/scripts/slave/recipe_modules/goma/example.expected/win_upload_logs.json
similarity index 78%
copy from scripts/slave/recipe_modules/goma/example.expected/win.json
copy to scripts/slave/recipe_modules/goma/example.expected/win_upload_logs.json
index 403b46a4a03fdddb7165bc2854786311f8b4fc81..1d1bac06bf87e1f676c11d79f932f9beef0dbc49 100644
--- a/scripts/slave/recipe_modules/goma/example.expected/win.json
+++ b/scripts/slave/recipe_modules/goma/example.expected/win_upload_logs.json
@@ -61,6 +61,8 @@
"restart"
],
"env": {
+ "GOMACTL_CRASH_REPORT_ID_FILE": "build_data_dir\\crash_report_id_file",
+ "GOMA_DUMP_STATS_FILE": "build_data_dir\\goma_stats_proto",
"GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-account-goma-client.json"
},
"name": "start_goma"
@@ -73,6 +75,8 @@
"stop"
],
"env": {
+ "GOMACTL_CRASH_REPORT_ID_FILE": "build_data_dir\\crash_report_id_file",
+ "GOMA_DUMP_STATS_FILE": "build_data_dir\\goma_stats_proto",
"GOMA_SERVICE_ACCOUNT_JSON_FILE": "C:\\creds\\service_accounts\\service-account-goma-client.json"
},
"name": "stop_goma"
@@ -82,7 +86,21 @@
"python",
"-u",
"RECIPE_PACKAGE_REPO[build]\\scripts\\slave\\upload_goma_logs.py",
- "--upload-compiler-proxy-info"
+ "--upload-compiler-proxy-info",
+ "--ninja-log-outdir",
+ "build_data_dir",
+ "--ninja-log-compiler",
+ "goma",
+ "--ninja-log-command",
+ "ninja -j 500",
+ "--ninja-log-exit-status",
+ "0",
+ "--goma-stats-file",
+ "build_data_dir\\goma_stats_proto",
+ "--goma-crash-report-id-file",
+ "build_data_dir\\crash_report_id_file",
+ "--build-data-dir",
+ "build_data_dir"
],
"name": "upload_log"
},
« no previous file with comments | « scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698