scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json - Issue 2232733002: Add test for upload_logs() in recipe_modules/goma

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json

Issue 2232733002: Add test for upload_logs() in recipe_modules/goma (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@goma_logs

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipe_modules/goma/example.expected/linux_upload_logs.json ('k') | scripts/slave/recipe_modules/goma/example.expected/win_upload_logs.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json

diff --git a/scripts/slave/recipe_modules/goma/example.expected/mac.json b/scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json

similarity index 78%

copy from scripts/slave/recipe_modules/goma/example.expected/mac.json

copy to scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json

index a7e7021556d9646272f9874bcdfadc9496f6f962..82427eb3ab46c1bedd19d161c92d98ef908fdc55 100644

--- a/scripts/slave/recipe_modules/goma/example.expected/mac.json

+++ b/scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json

@@ -61,6 +61,8 @@

"restart"

"env": {

+ "GOMACTL_CRASH_REPORT_ID_FILE": "build_data_dir/crash_report_id_file",

+ "GOMA_DUMP_STATS_FILE": "build_data_dir/goma_stats_proto",

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"

"name": "start_goma"

@@ -73,6 +75,8 @@

"stop"

"env": {

+ "GOMACTL_CRASH_REPORT_ID_FILE": "build_data_dir/crash_report_id_file",

+ "GOMA_DUMP_STATS_FILE": "build_data_dir/goma_stats_proto",

"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json"

"name": "stop_goma"

@@ -82,7 +86,21 @@

"python",

"-u",

"RECIPE_PACKAGE_REPO[build]/scripts/slave/upload_goma_logs.py",

- "--upload-compiler-proxy-info"

+ "--upload-compiler-proxy-info",

+ "--ninja-log-outdir",

+ "build_data_dir",

+ "--ninja-log-compiler",

+ "goma",

+ "--ninja-log-command",

+ "ninja -j 500",

+ "--ninja-log-exit-status",

+ "0",

+ "--goma-stats-file",

+ "build_data_dir/goma_stats_proto",

+ "--goma-crash-report-id-file",

+ "build_data_dir/crash_report_id_file",

+ "--build-data-dir",

+ "build_data_dir"

"name": "upload_log"