Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 2232733002: Add test for upload_logs() in recipe_modules/goma (Closed)

Created:
4 years, 4 months ago by tikuta
Modified:
4 years, 4 months ago
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@goma_logs
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Add test for upload_logs() in recipe_modules/goma This is follow up CL for https://codereview.chromium.org/2207273003 BUG=544330

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+76 lines, -5 lines) Patch
M scripts/slave/recipe_modules/goma/example.py View 1 chunk +19 lines, -2 lines 0 comments Download
A + scripts/slave/recipe_modules/goma/example.expected/linux_upload_logs.json View 3 chunks +19 lines, -1 line 0 comments Download
A + scripts/slave/recipe_modules/goma/example.expected/mac_upload_logs.json View 3 chunks +19 lines, -1 line 0 comments Download
A + scripts/slave/recipe_modules/goma/example.expected/win_upload_logs.json View 3 chunks +19 lines, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (5 generated)
tikuta
4 years, 4 months ago (2016-08-10 06:28:40 UTC) #5
Paweł Hajdan Jr.
LGTM
4 years, 4 months ago (2016-08-10 07:55:01 UTC) #6
tikuta
4 years, 4 months ago (2016-08-10 09:07:49 UTC) #7
I added test in
https://codereview.chromium.org/2207273003/

I close this.

Powered by Google App Engine
This is Rietveld 408576698