Chop off platform name from step name

appengine/findit/waterfall/test/try_job_util_test.py

Index: appengine/findit/waterfall/test/try_job_util_test.py
diff --git a/appengine/findit/waterfall/test/try_job_util_test.py b/appengine/findit/waterfall/test/try_job_util_test.py
index 6fd48a4a05f24ec9c11af78bbc33f019d6983086..e57f7ff21819687d8ff2f0ed28966df4e4c2559f 100644
--- a/appengine/findit/waterfall/test/try_job_util_test.py
+++ b/appengine/findit/waterfall/test/try_job_util_test.py
@@ -1193,6 +1193,17 @@ class TryJobUtilTest(wf_testcase.WaterfallTestCase):
             signals, 'master1', 'builder1'),
         ['b.o'])
 
+  def testChopOffPlatformFromStepName(self):
+    test_pairs = [
+        ('a_tests on Platform', 'a_tests on '),

[lijeffrey, 2016/08/10 18:48:08]

so why should the ' on ' be left in?

[lijeffrey, 2016/08/10 18:48:08]

it's easier just to make 1 for each of these

self.assertEqual(try_job_util.ChopOffPlatformFroStepName(...), ...)
self.assertEqual(...)
...

[josiahk, 2016/08/10 21:22:34]

So that 'super_tests on Windows' doesn't match 'super_tests'.

After discussing offline with Chan, the scenario of having 'step_a on
platform_x' and just 'step_a' shouldn't happen, so it shouldn't matter to
include ' on ' or not.

I think it's cleaner without the ' on ', and I took it out.

Thanks!

[josiahk, 2016/08/10 21:22:34]

Done.

+        ('a_tests on Other-Platform', 'a_tests on '),
+        ('b_tests', 'b_tests')]
+
+    for test_pair in test_pairs:
+      self.assertEqual(
+          try_job_util._ChopOffPlatformFromStepName(test_pair[0]),
+          test_pair[1])
+
   def testGetSuspectedCLsWithFailuresNoHeuristicResult(self):
     heuristic_result = None
     expected_suspected_revisions = []