Chop off platform name from step name

appengine/findit/waterfall/test/try_job_util_test.py

 # Copyright 2015 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 from datetime import datetime
 from datetime import timedelta
 
 from common.waterfall import failure_type
 from model import analysis_status
 from model.wf_analysis import WfAnalysis
@@ skipping 1175 matching lines @@
                 {'source': 'b.cc', 'target': 'b.o'},
             ]
         }
     }
 
     self.assertEqual(
         try_job_util._GetFailedTargetsFromSignals(
             signals, 'master1', 'builder1'),
         ['b.o'])
 
+  def testChopOffPlatformFromStepName(self):
+    test_pairs = [
+        ('a_tests on Platform', 'a_tests on '),

[lijeffrey, 2016/08/10 18:48:08]

so why should the ' on ' be left in?

[lijeffrey, 2016/08/10 18:48:08]

it's easier just to make 1 for each of these

self.assertEqual(try_job_util.ChopOffPlatformFroStepName(...), ...)
self.assertEqual(...)
...

[josiahk, 2016/08/10 21:22:34]

So that 'super_tests on Windows' doesn't match 'super_tests'.

After discussing offline with Chan, the scenario of having 'step_a on
platform_x' and just 'step_a' shouldn't happen, so it shouldn't matter to
include ' on ' or not.

I think it's cleaner without the ' on ', and I took it out.

Thanks!

[josiahk, 2016/08/10 21:22:34]

Done.

+        ('a_tests on Other-Platform', 'a_tests on '),
+        ('b_tests', 'b_tests')]
+
+    for test_pair in test_pairs:
+      self.assertEqual(
+          try_job_util._ChopOffPlatformFromStepName(test_pair[0]),
+          test_pair[1])
+
   def testGetSuspectedCLsWithFailuresNoHeuristicResult(self):
     heuristic_result = None
     expected_suspected_revisions = []
     self.assertEqual(
         expected_suspected_revisions,
         sorted(try_job_util.GetSuspectedCLsWithFailures(heuristic_result)))
 
   def testGetSuspectedCLsWithFailuresEmptyHeuristicResult(self):
     heuristic_result = {}
     expected_suspected_revisions = []
@@ skipping 115 matching lines @@
         try_job_util._GetSuspectsFromHeuristicResult(heuristic_result))
 
   def testShouldBailOutforOutdatedBuild(self):
     yesterday = datetime.utcnow() - timedelta(days=1)
     build = WfBuild.Create('m', 'b', 1)
     build.start_time = yesterday
     self.assertTrue(try_job_util._ShouldBailOutForOutdatedBuild(build))
 
     build.start_time = yesterday + timedelta(hours=1)
     self.assertFalse(try_job_util._ShouldBailOutForOutdatedBuild(build))