Generate default AP stream for ink annotation.

Generate default AP stream for ink annotation.

This patch generates a default AP stream for ink annotation so that ink
annotations without AP stream can be displayed.

Also, roll DEPS for testing/corpus to 4119f8e to test ink annotations.

BUG=62625
Committed: https://pdfium.googlesource.com/pdfium/+/39ba18a64283ef3fc3c4aedf537a09835f90862e

[jaepark, 2016-08-09 20:57:37]

jaepark@google.com changed reviewers:
+ thestig@chromium.org

[jaepark, 2016-08-09 20:57:38]

Need to roll DEPS after landing test cases
(https://codereview.chromium.org/2224213004).

[Lei Zhang, 2016-08-09 21:38:57]

lgtm

lgtm

https://codereview.chromium.org/2232553002/diff/1/core/fpdfdoc/cpvt_generatea...
File core/fpdfdoc/cpvt_generateap.cpp (right):

https://codereview.chromium.org/2232553002/diff/1/core/fpdfdoc/cpvt_generatea...
core/fpdfdoc/cpvt_generateap.cpp:763: for (size_t i = 0; i <
pInkCoordList->GetCount() - 1; i += 2) {
This |i| is a shadow variable. Time for |j|.

[Lei Zhang, 2016-08-09 21:38:57]

lgtm

https://codereview.chromium.org/2232553002/diff/1/core/fpdfdoc/cpvt_generatea...
File core/fpdfdoc/cpvt_generateap.cpp (right):

https://codereview.chromium.org/2232553002/diff/1/core/fpdfdoc/cpvt_generatea...
core/fpdfdoc/cpvt_generateap.cpp:763: for (size_t i = 0; i <
pInkCoordList->GetCount() - 1; i += 2) {
This |i| is a shadow variable. Time for |j|.

[jaepark, 2016-08-09 21:53:08]

Description was changed from

==========
Generate default AP stream for ink annotation.

This patch generates a default AP stream for ink annotation so that ink
annotations without AP stream can be displayed.

BUG=62625
==========

to

==========
Generate default AP stream for ink annotation.

This patch generates a default AP stream for ink annotation so that ink
annotations without AP stream can be displayed.

Also, roll DEPS for testing/corpus to 4119f8e to test ink annotations.

BUG=62625
==========

[jaepark, 2016-08-09 21:55:24]

The CQ bit was checked by jaepark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-08-09 21:55:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 22:07:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-09 22:07:14]

Dry run: This issue passed the CQ dry run.

[jaepark, 2016-08-09 22:19:09]

https://codereview.chromium.org/2232553002/diff/1/core/fpdfdoc/cpvt_generatea...
File core/fpdfdoc/cpvt_generateap.cpp (right):

https://codereview.chromium.org/2232553002/diff/1/core/fpdfdoc/cpvt_generatea...
core/fpdfdoc/cpvt_generateap.cpp:763: for (size_t i = 0; i <
pInkCoordList->GetCount() - 1; i += 2) {
On 2016/08/09 21:38:57, Lei Zhang wrote:
> This |i| is a shadow variable. Time for |j|.

Done.

[jaepark, 2016-08-09 22:19:15]

The CQ bit was checked by jaepark@google.com

[jaepark, 2016-08-09 22:19:15]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2232553002/#ps20001
(title: "Generate default AP stream for ink annotation.")

[commit-bot: I haz the power, 2016-08-09 22:19:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-09 22:19:39]

Description was changed from

==========
Generate default AP stream for ink annotation.

This patch generates a default AP stream for ink annotation so that ink
annotations without AP stream can be displayed.

Also, roll DEPS for testing/corpus to 4119f8e to test ink annotations.

BUG=62625
==========

to

==========
Generate default AP stream for ink annotation.

This patch generates a default AP stream for ink annotation so that ink
annotations without AP stream can be displayed.

Also, roll DEPS for testing/corpus to 4119f8e to test ink annotations.

BUG=62625

Committed:
https://pdfium.googlesource.com/pdfium/+/39ba18a64283ef3fc3c4aedf537a09835f90...
==========

[commit-bot: I haz the power, 2016-08-09 22:19:40]

Committed patchset #2 (id:20001) as
https://pdfium.googlesource.com/pdfium/+/39ba18a64283ef3fc3c4aedf537a09835f90...