Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(792)

Issue 2232343002: [ast] Never declare non-lexical variables as kNeedsInitialization. (Closed)

Created:
4 years, 4 months ago by neis
Modified:
4 years, 4 months ago
Reviewers:
adamk
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[ast] Never declare non-lexical variables as kNeedsInitialization. R=adamk@chromium.org BUG= Committed: https://crrev.com/63f311ad3493344b3d12d63ec9537ebbe1a714d0 Cr-Commit-Position: refs/heads/master@{#38589}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -3 lines) Patch
M src/ast/scopes.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M src/ast/variables.h View 1 chunk +2 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 12 (6 generated)
neis
4 years, 4 months ago (2016-08-11 17:12:24 UTC) #1
adamk
lgtm The truth of the matter is we can't tell when we have a dynamic ...
4 years, 4 months ago (2016-08-11 17:17:48 UTC) #4
neis
On 2016/08/11 17:17:48, adamk wrote: > lgtm > > The truth of the matter is ...
4 years, 4 months ago (2016-08-11 17:19:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2232343002/1
4 years, 4 months ago (2016-08-11 17:43:10 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-11 17:44:55 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 17:45:08 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/63f311ad3493344b3d12d63ec9537ebbe1a714d0
Cr-Commit-Position: refs/heads/master@{#38589}

Powered by Google App Engine
This is Rietveld 408576698