Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2232313002: [interpreter] Simplify hole check condition for variable assignments. (Closed)

Created:
4 years, 4 months ago by neis
Modified:
4 years, 4 months ago
Reviewers:
adamk, rmcilroy
CC:
v8-reviews_googlegroups.com, oth, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[interpreter] Simplify hole check condition for variable assignments. There's no need to check IsLexicalVariableMode since it's subsumed by binding_needs_init. Drive-by change: in VisitVariableLoad, move SetResultInAccumulator out of switch cases. BUG= Committed: https://crrev.com/93ad996e2859990831a717629909b68c00acbda0 Cr-Commit-Position: refs/heads/master@{#38590}

Patch Set 1 #

Patch Set 2 : Rebase on top of my other CL. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -7 lines) Patch
M src/interpreter/bytecode-generator.cc View 4 chunks +2 lines, -7 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 16 (10 generated)
neis
ptal
4 years, 4 months ago (2016-08-11 17:25:48 UTC) #6
adamk
lgtm
4 years, 4 months ago (2016-08-11 17:29:32 UTC) #7
rmcilroy
lgtm
4 years, 4 months ago (2016-08-11 17:36:59 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2232313002/20001
4 years, 4 months ago (2016-08-11 17:45:40 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-11 17:47:20 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 17:47:39 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/93ad996e2859990831a717629909b68c00acbda0
Cr-Commit-Position: refs/heads/master@{#38590}

Powered by Google App Engine
This is Rietveld 408576698