Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Issue 2232323004: Blink-compatible serialization of numbers. (Closed)

Created:
4 years, 4 months ago by jbroman
Modified:
4 years, 4 months ago
Reviewers:
Camillo Bruni
CC:
esprehn, jochen (gone - plz use gerrit), v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@vs1
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Blink-compatible serialization of numbers. This includes unsigned integers (encoded as base-128 varints), signed integers (ZigZag-encoded, then varint-encoded) and doubles (written in host byte order). BUG=chromium:148757 Committed: https://crrev.com/39bbb6f22a36c434f96f91233e5370c9cd4b16b7 Cr-Commit-Position: refs/heads/master@{#38630}

Patch Set 1 #

Patch Set 2 : remove big-endian tests, since I cannot actually run them #

Patch Set 3 : . #

Patch Set 4 : for consistency, use sizeof(double) everywhere #

Unified diffs Side-by-side diffs Delta from patch set Stats (+185 lines, -1 line) Patch
M src/value-serializer.h View 3 chunks +10 lines, -0 lines 0 comments Download
M src/value-serializer.cc View 1 2 3 5 chunks +90 lines, -1 line 0 comments Download
M test/unittests/value-serializer-unittest.cc View 1 2 2 chunks +85 lines, -0 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 16 (11 generated)
jbroman
4 years, 4 months ago (2016-08-12 15:18:58 UTC) #7
Camillo Bruni
lgtm
4 years, 4 months ago (2016-08-14 15:19:31 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2232323004/60001
4 years, 4 months ago (2016-08-15 00:39:20 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 4 months ago (2016-08-15 01:00:24 UTC) #14
commit-bot: I haz the power
4 years, 4 months ago (2016-08-15 01:00:43 UTC) #16
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/39bbb6f22a36c434f96f91233e5370c9cd4b16b7
Cr-Commit-Position: refs/heads/master@{#38630}

Powered by Google App Engine
This is Rietveld 408576698