Blink-compatible serialization of strings.

Blink-compatible serialization of strings.

This includes UTF-8 strings and two-byte strings, both length-delimited
(in bytes, not characters). Two-byte strings are written/read in host byte
order.

BUG=chromium:148757
Committed: https://crrev.com/c5701e166ed3eee6f731ff1ec8ccac3c8ff85192
Cr-Commit-Position: refs/heads/master@{#38636}

[jbroman, 2016-08-12 19:28:56]

jbroman@chromium.org changed reviewers:
+ cbruni@chromium.org

[Camillo Bruni, 2016-08-14 15:10:49]

LGTM

https://codereview.chromium.org/2245753002/diff/80001/src/value-serializer.cc
File src/value-serializer.cc (right):

https://codereview.chromium.org/2245753002/diff/80001/src/value-serializer.cc...
src/value-serializer.cc:202: uint32_t utf8_length = api_string->Utf8Length();
performance nit: I'd prefer not wrapping the Handle<String> into a Local. Funily
enough, all the API functions (Utf8Length and WriteUtf8) use the a
Handle<String> internally. So at some point you can just provide the
Handle<String>-based helper separately.

[jbroman, 2016-08-15 01:33:52]

https://codereview.chromium.org/2245753002/diff/80001/src/value-serializer.cc
File src/value-serializer.cc (right):

https://codereview.chromium.org/2245753002/diff/80001/src/value-serializer.cc...
src/value-serializer.cc:202: uint32_t utf8_length = api_string->Utf8Length();
On 2016/08/14 at 15:10:48, Camillo Bruni wrote:
> performance nit: I'd prefer not wrapping the Handle<String> into a Local.
Funily enough, all the API functions (Utf8Length and WriteUtf8) use the a
Handle<String> internally. So at some point you can just provide the
Handle<String>-based helper separately.

Agreed that wrapping in a Local<> isn't great. Ideally I'd like to add a new tag
for one-byte strings and then stop writing out UTF-8 altogether (decoding it
would still be required, but that doesn't have to use a Local<>). If that
doesn't come together, then that refactor sounds reasonable to me.

[jbroman, 2016-08-15 01:33:58]

The CQ bit was checked by jbroman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-15 01:34:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 01:37:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-15 01:37:58]

Dry run: Try jobs failed on following builders:
  v8_win_compile_dbg on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_compile_dbg/builds/2...)
  v8_win_rel_ng on master.tryserver.v8 (JOB_FAILED,
http://build.chromium.org/p/tryserver.v8/builders/v8_win_rel_ng/builds/12476)

[jbroman, 2016-08-15 14:51:30]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2016-08-15 14:51:30]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/2245753002/#ps100001
(title: "make windows happy (and be slightly more restrictive on platforms where
sizeof(int) == 8)")

[commit-bot: I haz the power, 2016-08-15 14:51:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jbroman, 2016-08-15 14:54:05]

The CQ bit was checked by jbroman@chromium.org

[jbroman, 2016-08-15 14:54:06]

The patchset sent to the CQ was uploaded after l-g-t-m from cbruni@chromium.org
Link to the patchset: https://codereview.chromium.org/2245753002/#ps120001
(title: "explicit cast to actually make it an unsigned comparison")

[commit-bot: I haz the power, 2016-08-15 14:54:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-15 15:26:45]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-08-15 15:27:17]

Description was changed from

==========
Blink-compatible serialization of strings.

This includes UTF-8 strings and two-byte strings, both length-delimited
(in bytes, not characters). Two-byte strings are written/read in host byte
order.

BUG=chromium:148757
==========

to

==========
Blink-compatible serialization of strings.

This includes UTF-8 strings and two-byte strings, both length-delimited
(in bytes, not characters). Two-byte strings are written/read in host byte
order.

BUG=chromium:148757

Committed: https://crrev.com/c5701e166ed3eee6f731ff1ec8ccac3c8ff85192
Cr-Commit-Position: refs/heads/master@{#38636}
==========

[commit-bot: I haz the power, 2016-08-15 15:27:18]

Patchset 7 (id:??) landed as
https://crrev.com/c5701e166ed3eee6f731ff1ec8ccac3c8ff85192
Cr-Commit-Position: refs/heads/master@{#38636}