Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 2232303002: Overhaul the README files a bit. (Closed)

Created:
4 years, 4 months ago by M-A Ruel
Modified:
4 years, 4 months ago
Reviewers:
tandrii(chromium)
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Overhaul the README files a bit. I didn't change the content much but deleted some obviously wrong stuff. Renamed the files to .md so they will be processed by gitiles. This change is in no way "sufficient" but that's a start. R=tandrii@chromium.org Committed: https://chromium.googlesource.com/chromium/tools/depot_tools/+/9e198a84a930530032d87318b8c33b62b8b3833f

Patch Set 1 #

Total comments: 4

Patch Set 2 : Use better example #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+216 lines, -269 lines) Patch
D README.codereview View 1 chunk +0 lines, -99 lines 0 comments Download
D README.gclient View 1 chunk +0 lines, -82 lines 0 comments Download
D README.git-cl View 1 chunk +0 lines, -52 lines 0 comments Download
M README.md View 1 chunk +50 lines, -36 lines 0 comments Download
A README.gclient.md View 1 1 chunk +67 lines, -0 lines 1 comment Download
A README.git-cl.md View 1 chunk +99 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
M-A Ruel
4 years, 4 months ago (2016-08-11 15:10:46 UTC) #1
tandrii(chromium)
THANKS! LGTM. I should totally edit git cl stuff with Gerrit info. https://codereview.chromium.org/2232303002/diff/1/README.gclient.md File README.gclient.md ...
4 years, 4 months ago (2016-08-11 15:18:19 UTC) #2
M-A Ruel
hillariously, the presubmit fails for me. Oh well. https://codereview.chromium.org/2232303002/diff/1/README.gclient.md File README.gclient.md (right): https://codereview.chromium.org/2232303002/diff/1/README.gclient.md#newcode53 README.gclient.md:53: "src/component" ...
4 years, 4 months ago (2016-08-11 15:28:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2232303002/20001
4 years, 4 months ago (2016-08-11 15:29:29 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001) as https://chromium.googlesource.com/chromium/tools/depot_tools/+/9e198a84a930530032d87318b8c33b62b8b3833f
4 years, 4 months ago (2016-08-11 15:32:24 UTC) #8
tandrii(chromium)
well, CQ's presubmit works fine. https://codereview.chromium.org/2232303002/diff/20001/README.gclient.md File README.gclient.md (right): https://codereview.chromium.org/2232303002/diff/20001/README.gclient.md#newcode53 README.gclient.md:53: "src/component": "https://dont-use-github.com/its/unreliable.git@0000000000000000000000000000000000000000", Yeah, +1
4 years, 4 months ago (2016-08-11 16:01:11 UTC) #9
anatoly techtonik
4 years, 4 months ago (2016-08-11 18:00:47 UTC) #10
Message was sent while issue was closed.
Gratz with goat teleporting finally fixed. =)

Powered by Google App Engine
This is Rietveld 408576698