Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Issue 2232223003: [CacheStorage] Check doomed caches first when dropping cache handles (Closed)

Created:
4 years, 4 months ago by jkarlin
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews, blink-reviews, darin-cc_chromium.org, jam, jkarlin+watch_chromium.org, nhiroki
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

This is a merge into M53 (branch 2785) [CacheStorage] Check doomed caches first when dropping cache handles When the last cache handle is dropped, first check if it's a doomed cache object before removing the cache from the active cache map. Previously we were checking the other way around, which caused the active cache to be deleted (in the event that a new cache was created with the same name) instead of the doomed one. BUG=631467 Review-Url: https://codereview.chromium.org/2179353003 Cr-Commit-Position: refs/heads/master@{#407850} (cherry picked from commit 956d7aca53f56b5cff228af586ea2e5f895f2e9b) [CacheStorage] Keep deleted caches alive until last reference is gone Currently once a cache is deleted via CacheStorage::Delete the associated CacheStorageCache is closed and subsequent calls to it fail. This CL keeps the CacheStorageCache alive, waiting to delete it from disk until after the last cache handle has been dropped. This change is to conform with the spec. BUG=618646 Review-Url: https://codereview.chromium.org/2111243003 Cr-Commit-Position: refs/heads/master@{#403837} (cherry picked from commit 0903d9b86a61912208efe95f24d0c79099ebf371) Committed: https://chromium.googlesource.com/chromium/src/+/6f11a8f8d45b8f49980f3eccf71de1f75618ae07

Patch Set 1 #

Patch Set 2 : Rebase #

Messages

Total messages: 3 (2 generated)
jkarlin
4 years, 4 months ago (2016-08-11 14:30:11 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
6f11a8f8d45b8f49980f3eccf71de1f75618ae07.

Powered by Google App Engine
This is Rietveld 408576698