[CacheStorage] Check doomed caches first when dropping cache handles

[CacheStorage] Check doomed caches first when dropping cache handles

When the last cache handle is dropped, first check if it's a doomed cache
object before removing the cache from the active cache map. Previously we were
checking the other way around, which caused the active cache to be deleted (in
the event that a new cache was created with the same name) instead of the doomed
one.

BUG=631467
Committed: https://crrev.com/956d7aca53f56b5cff228af586ea2e5f895f2e9b
Cr-Commit-Position: refs/heads/master@{#407850}

[jkarlin, 2016-07-26 13:55:40]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 13:55:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 14:13:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 14:13:52]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[jkarlin, 2016-07-26 15:10:54]

The CQ bit was checked by jkarlin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-26 15:11:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[jkarlin, 2016-07-26 15:40:14]

Description was changed from

==========
[CacheStorage] Check doomed caches first when dropping cache handles

When the last cache handle is dropped, first check if it's a doomed cache
object before removing the cache from the active cache map. Previously we were
checking the other way around, which caused the attached bug.

BUG=631467
==========

to

==========
[CacheStorage] Check doomed caches first when dropping cache handles

When the last cache handle is dropped, first check if it's a doomed cache
object before removing the cache from the active cache map. Previously we were
checking the other way around, which caused the referenced bug.

BUG=631467
==========

[jkarlin, 2016-07-26 15:41:08]

Description was changed from

==========
[CacheStorage] Check doomed caches first when dropping cache handles

When the last cache handle is dropped, first check if it's a doomed cache
object before removing the cache from the active cache map. Previously we were
checking the other way around, which caused the referenced bug.

BUG=631467
==========

to

==========
[CacheStorage] Check doomed caches first when dropping cache handles

When the last cache handle is dropped, first check if it's a doomed cache
object before removing the cache from the active cache map. Previously we were
checking the other way around, which caused the active cache to be deleted (in 
the event that a new cache was created with the same name) instead of the doomed
one.

BUG=631467
==========

[jkarlin, 2016-07-26 16:29:02]

jkarlin@chromium.org changed reviewers:
+ jsbell@chromium.org

[jkarlin, 2016-07-26 16:29:23]

jsbell@ PTAL, thanks!

[commit-bot: I haz the power, 2016-07-26 16:33:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-26 16:33:16]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jsbell, 2016-07-26 17:23:26]

lgtm

[jkarlin, 2016-07-26 17:24:52]

The CQ bit was checked by jkarlin@chromium.org

[commit-bot: I haz the power, 2016-07-26 17:25:09]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-26 17:58:37]

Description was changed from

==========
[CacheStorage] Check doomed caches first when dropping cache handles

When the last cache handle is dropped, first check if it's a doomed cache
object before removing the cache from the active cache map. Previously we were
checking the other way around, which caused the active cache to be deleted (in 
the event that a new cache was created with the same name) instead of the doomed
one.

BUG=631467
==========

to

==========
[CacheStorage] Check doomed caches first when dropping cache handles

When the last cache handle is dropped, first check if it's a doomed cache
object before removing the cache from the active cache map. Previously we were
checking the other way around, which caused the active cache to be deleted (in 
the event that a new cache was created with the same name) instead of the doomed
one.

BUG=631467
==========

[commit-bot: I haz the power, 2016-07-26 17:58:38]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-26 18:03:22]

Description was changed from

==========
[CacheStorage] Check doomed caches first when dropping cache handles

When the last cache handle is dropped, first check if it's a doomed cache
object before removing the cache from the active cache map. Previously we were
checking the other way around, which caused the active cache to be deleted (in 
the event that a new cache was created with the same name) instead of the doomed
one.

BUG=631467
==========

to

==========
[CacheStorage] Check doomed caches first when dropping cache handles

When the last cache handle is dropped, first check if it's a doomed cache
object before removing the cache from the active cache map. Previously we were
checking the other way around, which caused the active cache to be deleted (in
the event that a new cache was created with the same name) instead of the doomed
one.

BUG=631467

Committed: https://crrev.com/956d7aca53f56b5cff228af586ea2e5f895f2e9b
Cr-Commit-Position: refs/heads/master@{#407850}
==========

[commit-bot: I haz the power, 2016-07-26 18:03:24]

Patchset 2 (id:??) landed as
https://crrev.com/956d7aca53f56b5cff228af586ea2e5f895f2e9b
Cr-Commit-Position: refs/heads/master@{#407850}