Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(239)

Unified Diff: third_party/WebKit/Source/core/css/CSSPrimitiveValue.h

Issue 2232093002: Removed parent data storage common to multiple CSSValues (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Tried re-ordering fields to fix larger size on windows Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/css/CSSPrimitiveValue.h
diff --git a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h
index 7bf785bbd689f718e58784961770994bdfee7007..eae4ed340f10f0c31167d21dd517e21fa3fc0fdd 100644
--- a/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h
+++ b/third_party/WebKit/Source/core/css/CSSPrimitiveValue.h
@@ -271,6 +271,8 @@ private:
template<typename T> CSSPrimitiveValue(T* val)
: CSSValue(PrimitiveClass)
+ , m_primitiveUnitType(0)
+ , m_hasCachedCSSText(false)
{
init(val);
}
@@ -290,13 +292,15 @@ private:
double computeLengthDouble(const CSSToLengthConversionData&) const;
inline UnitType type() const { return static_cast<UnitType>(m_primitiveUnitType); }
-
union {
CSSValueID valueID;
double num;
// FIXME: oilpan: Should be a member, but no support for members in unions. Just trace the raw ptr for now.
CSSCalcValue* calc;
} m_value;
+
+ unsigned m_primitiveUnitType : 7; // CSSPrimitiveValue::UnitType
+ mutable unsigned m_hasCachedCSSText : 1;
};
using CSSLengthArray = CSSPrimitiveValue::CSSLengthArray;
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSPrimitiveValue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698