third_party/WebKit/Source/wtf/text/StringImpl.h - Issue 2232083002: Fix incorrect usage of StringImpl::sizeInBytes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/StringImpl.h

Issue 2232083002: Fix incorrect usage of StringImpl::sizeInBytes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: size_teeee Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/StringImpl.h

diff --git a/third_party/WebKit/Source/wtf/text/StringImpl.h b/third_party/WebKit/Source/wtf/text/StringImpl.h

index 30736e2e2fc1bcd33c5d600d5b75d61e7ebffb5a..bbb92eceebf2195c8eed8fffee13742b5ba0653c 100644

--- a/third_party/WebKit/Source/wtf/text/StringImpl.h

+++ b/third_party/WebKit/Source/wtf/text/StringImpl.h

@@ -229,7 +229,10 @@ public:

template <typename CharType>

ALWAYS_INLINE const CharType * getCharacters() const;

- size_t sizeInBytes() const;

+ size_t charactersSizeInBytes() const

+ {

+ return length() * (is8Bit() ? sizeof(LChar) : sizeof(UChar));

+ }

bool isAtomic() const { return m_isAtomic; }

void setIsAtomic(bool isAtomic) { m_isAtomic = isAtomic; }