third_party/WebKit/Source/wtf/text/StringImpl.cpp - Issue 2232083002: Fix incorrect usage of StringImpl::sizeInBytes.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/wtf/text/StringImpl.cpp

Issue 2232083002: Fix incorrect usage of StringImpl::sizeInBytes. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: size_teeee Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/wtf/text/StringImpl.cpp

diff --git a/third_party/WebKit/Source/wtf/text/StringImpl.cpp b/third_party/WebKit/Source/wtf/text/StringImpl.cpp

index 850f9865ac606198c28768a81febec66f40264c6..728c076c8500db5c35fb923c2124f38bd09a38c3 100644

--- a/third_party/WebKit/Source/wtf/text/StringImpl.cpp

+++ b/third_party/WebKit/Source/wtf/text/StringImpl.cpp

@@ -1992,14 +1992,6 @@ int codePointCompareIgnoringASCIICase(const StringImpl* string1, const LChar* st

return codePointCompareIgnoringASCIICase(length1, length2, string1->characters16(), string2);

}

-size_t StringImpl::sizeInBytes() const

- size_t size = length();

- if (!is8Bit())

- size *= 2;

- return size + sizeof(*this);

UChar32 toUpper(UChar32 c, const AtomicString& localeIdentifier)

{

if (!localeIdentifier.isNull()) {