Fix incorrect usage of StringImpl::sizeInBytes.

Fix incorrect usage of StringImpl::sizeInBytes.

Confusingly StringImpl::sizeInBytes and String::sizeInBytes return totally
different things!

- StringImpl's method returns the size of the storage for the characters *plus* the
size of the StringImpl object overhead.

- String's method returns just the size of the storage for the characters.

This patch makes them both return the size of the storage for the characters which
is actually what everyone wants and renames the method charactersSizeInBytes().

Thankfully the only confused caller was NetworkResourcesData in the inspector.

I also removed the memoryConsumption() method in StringResource which was just
duplicating this method and added a method to AtomicString so it has the same
API as String.

I also switched to size_t for the return value of charactersSizeInBytes() because
the length of a string can be nearly UINT_MAX, and sizeof(UChar) is 2, which
means a very large string could have caused overflow here on 64bit machines.

Finally I fixed a potential integer overflow in StringResource where we were
negating the unsigned value returned from sizeInBytes() and assigning to an int,
then subtracting from it the size of the AtomicString if it exists.

Committed: https://crrev.com/3d24a7c4d0c8ede0dffb89b1e7d9e3340f7e7546
Cr-Commit-Position: refs/heads/master@{#411351}

[esprehn, 2016-08-11 03:37:59]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 03:38:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 03:50:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 03:50:54]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[esprehn, 2016-08-11 04:10:25]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 04:10:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-08-11 04:17:07]

Description was changed from

==========
Fix size in bytes.

BUG=
==========

to

==========
Fix incorrect usage of StringImpl::sizeInBytes.

Confusingly StringImpl::sizeInBytes and String::sizeInBytes return totally
different things!

- StringImpl's method returns the size of the storage for the characters *plus*
the
size of the StringImpl object overhead.

- String's method returns just the size of the storage for the characters.

This patch makes them both return the size of the storage for the characters
which
is actually what everyone wants and renames the method charactersSizeInBytes().

Thankfully the only confused caller was NetworkResourcesData in the inspector.

I also removed the memoryConsumption() method in StringResource which was just
duplicating this method and added a method to AtomicString so it has the same
API has String.
==========

[esprehn, 2016-08-11 04:20:12]

Description was changed from

==========
Fix incorrect usage of StringImpl::sizeInBytes.

Confusingly StringImpl::sizeInBytes and String::sizeInBytes return totally
different things!

- StringImpl's method returns the size of the storage for the characters *plus*
the
size of the StringImpl object overhead.

- String's method returns just the size of the storage for the characters.

This patch makes them both return the size of the storage for the characters
which
is actually what everyone wants and renames the method charactersSizeInBytes().

Thankfully the only confused caller was NetworkResourcesData in the inspector.

I also removed the memoryConsumption() method in StringResource which was just
duplicating this method and added a method to AtomicString so it has the same
API has String.
==========

to

==========
Fix incorrect usage of StringImpl::sizeInBytes.

Confusingly StringImpl::sizeInBytes and String::sizeInBytes return totally
different things!

- StringImpl's method returns the size of the storage for the characters *plus*
the
size of the StringImpl object overhead.

- String's method returns just the size of the storage for the characters.

This patch makes them both return the size of the storage for the characters
which
is actually what everyone wants and renames the method charactersSizeInBytes().

Thankfully the only confused caller was NetworkResourcesData in the inspector.

I also removed the memoryConsumption() method in StringResource which was just
duplicating this method and added a method to AtomicString so it has the same
API has String.

Finally I fixed a potential integer overflow in StringResource where we were
negating the unsigned value returned from sizeInBytes() and assigning to an int,
then subtracting from it the size of the AtomicString if it exists.
==========

[commit-bot: I haz the power, 2016-08-11 04:39:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 04:39:23]

Dry run: Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[esprehn, 2016-08-11 05:12:56]

The CQ bit was checked by esprehn@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 05:13:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[esprehn, 2016-08-11 05:47:02]

Description was changed from

==========
Fix incorrect usage of StringImpl::sizeInBytes.

Confusingly StringImpl::sizeInBytes and String::sizeInBytes return totally
different things!

- StringImpl's method returns the size of the storage for the characters *plus*
the
size of the StringImpl object overhead.

- String's method returns just the size of the storage for the characters.

This patch makes them both return the size of the storage for the characters
which
is actually what everyone wants and renames the method charactersSizeInBytes().

Thankfully the only confused caller was NetworkResourcesData in the inspector.

I also removed the memoryConsumption() method in StringResource which was just
duplicating this method and added a method to AtomicString so it has the same
API has String.

Finally I fixed a potential integer overflow in StringResource where we were
negating the unsigned value returned from sizeInBytes() and assigning to an int,
then subtracting from it the size of the AtomicString if it exists.
==========

to

==========
Fix incorrect usage of StringImpl::sizeInBytes.

Confusingly StringImpl::sizeInBytes and String::sizeInBytes return totally
different things!

- StringImpl's method returns the size of the storage for the characters *plus*
the
size of the StringImpl object overhead.

- String's method returns just the size of the storage for the characters.

This patch makes them both return the size of the storage for the characters
which
is actually what everyone wants and renames the method charactersSizeInBytes().

Thankfully the only confused caller was NetworkResourcesData in the inspector.

I also removed the memoryConsumption() method in StringResource which was just
duplicating this method and added a method to AtomicString so it has the same
API has String.

I also switched to size_t for the return value of charactersSizeInBytes()
because
the length of a string can be nearly UINT_MAX, and sizeof(UChar) is 2, which
means a very large string could have caused overflow here on 64bit machines.

Finally I fixed a potential integer overflow in StringResource where we were
negating the unsigned value returned from sizeInBytes() and assigning to an int,
then subtracting from it the size of the AtomicString if it exists.
==========

[esprehn, 2016-08-11 06:16:12]

esprehn@chromium.org changed reviewers:
+ haraken@chromium.org, yutak@chromium.org, yzshen@chromium.org

[commit-bot: I haz the power, 2016-08-11 08:14:26]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 08:14:27]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-08-11 12:13:20]

LGTM

[yzshen1, 2016-08-11 16:20:37]

On 2016/08/11 12:13:20, haraken wrote:
> LGTM

LGTM!

[esprehn, 2016-08-11 16:23:24]

Description was changed from

==========
Fix incorrect usage of StringImpl::sizeInBytes.

Confusingly StringImpl::sizeInBytes and String::sizeInBytes return totally
different things!

- StringImpl's method returns the size of the storage for the characters *plus*
the
size of the StringImpl object overhead.

- String's method returns just the size of the storage for the characters.

This patch makes them both return the size of the storage for the characters
which
is actually what everyone wants and renames the method charactersSizeInBytes().

Thankfully the only confused caller was NetworkResourcesData in the inspector.

I also removed the memoryConsumption() method in StringResource which was just
duplicating this method and added a method to AtomicString so it has the same
API has String.

I also switched to size_t for the return value of charactersSizeInBytes()
because
the length of a string can be nearly UINT_MAX, and sizeof(UChar) is 2, which
means a very large string could have caused overflow here on 64bit machines.

Finally I fixed a potential integer overflow in StringResource where we were
negating the unsigned value returned from sizeInBytes() and assigning to an int,
then subtracting from it the size of the AtomicString if it exists.
==========

to

==========
Fix incorrect usage of StringImpl::sizeInBytes.

Confusingly StringImpl::sizeInBytes and String::sizeInBytes return totally
different things!

- StringImpl's method returns the size of the storage for the characters *plus*
the
size of the StringImpl object overhead.

- String's method returns just the size of the storage for the characters.

This patch makes them both return the size of the storage for the characters
which
is actually what everyone wants and renames the method charactersSizeInBytes().

Thankfully the only confused caller was NetworkResourcesData in the inspector.

I also removed the memoryConsumption() method in StringResource which was just
duplicating this method and added a method to AtomicString so it has the same
API as String.

I also switched to size_t for the return value of charactersSizeInBytes()
because
the length of a string can be nearly UINT_MAX, and sizeof(UChar) is 2, which
means a very large string could have caused overflow here on 64bit machines.

Finally I fixed a potential integer overflow in StringResource where we were
negating the unsigned value returned from sizeInBytes() and assigning to an int,
then subtracting from it the size of the AtomicString if it exists.
==========

[esprehn, 2016-08-11 16:25:42]

The CQ bit was checked by esprehn@chromium.org

[commit-bot: I haz the power, 2016-08-11 16:25:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 16:30:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-11 16:33:05]

Description was changed from

==========
Fix incorrect usage of StringImpl::sizeInBytes.

Confusingly StringImpl::sizeInBytes and String::sizeInBytes return totally
different things!

- StringImpl's method returns the size of the storage for the characters *plus*
the
size of the StringImpl object overhead.

- String's method returns just the size of the storage for the characters.

This patch makes them both return the size of the storage for the characters
which
is actually what everyone wants and renames the method charactersSizeInBytes().

Thankfully the only confused caller was NetworkResourcesData in the inspector.

I also removed the memoryConsumption() method in StringResource which was just
duplicating this method and added a method to AtomicString so it has the same
API as String.

I also switched to size_t for the return value of charactersSizeInBytes()
because
the length of a string can be nearly UINT_MAX, and sizeof(UChar) is 2, which
means a very large string could have caused overflow here on 64bit machines.

Finally I fixed a potential integer overflow in StringResource where we were
negating the unsigned value returned from sizeInBytes() and assigning to an int,
then subtracting from it the size of the AtomicString if it exists.
==========

to

==========
Fix incorrect usage of StringImpl::sizeInBytes.

Confusingly StringImpl::sizeInBytes and String::sizeInBytes return totally
different things!

- StringImpl's method returns the size of the storage for the characters *plus*
the
size of the StringImpl object overhead.

- String's method returns just the size of the storage for the characters.

This patch makes them both return the size of the storage for the characters
which
is actually what everyone wants and renames the method charactersSizeInBytes().

Thankfully the only confused caller was NetworkResourcesData in the inspector.

I also removed the memoryConsumption() method in StringResource which was just
duplicating this method and added a method to AtomicString so it has the same
API as String.

I also switched to size_t for the return value of charactersSizeInBytes()
because
the length of a string can be nearly UINT_MAX, and sizeof(UChar) is 2, which
means a very large string could have caused overflow here on 64bit machines.

Finally I fixed a potential integer overflow in StringResource where we were
negating the unsigned value returned from sizeInBytes() and assigning to an int,
then subtracting from it the size of the AtomicString if it exists.

Committed: https://crrev.com/3d24a7c4d0c8ede0dffb89b1e7d9e3340f7e7546
Cr-Commit-Position: refs/heads/master@{#411351}
==========

[commit-bot: I haz the power, 2016-08-11 16:33:08]

Patchset 3 (id:??) landed as
https://crrev.com/3d24a7c4d0c8ede0dffb89b1e7d9e3340f7e7546
Cr-Commit-Position: refs/heads/master@{#411351}