src/objects-printer.cc - Issue 223193005: Get rid of the TRANSITION PropertyType and consistently use CanHoldValue().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects-printer.cc

Issue 223193005: Get rid of the TRANSITION PropertyType and consistently use CanHoldValue(). (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Use GetPropertyDetails() instead of GetLastDescriptorDetails(). Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects-printer.cc

diff --git a/src/objects-printer.cc b/src/objects-printer.cc

index 518167cc51e0d63216056f51b5508fdd94424b0e..a59b1e9ae8094a9c171192674ba0c48b27cd9b56 100644

--- a/src/objects-printer.cc

+++ b/src/objects-printer.cc

@@ -271,7 +271,6 @@ void JSObject::PrintProperties(FILE* out) {

case HANDLER: // only in lookup results, not in descriptors

case INTERCEPTOR: // only in lookup results, not in descriptors

// There are no transitions in the descriptor array.

Igor Sheludko 2014/04/04 15:42:11 Does this comment still make sense?

- case TRANSITION:

case NONEXISTENT:

UNREACHABLE();

break;

@@ -428,7 +427,6 @@ void JSObject::PrintTransitions(FILE* out) {

case NORMAL:

case HANDLER:

case INTERCEPTOR:

- case TRANSITION:

case NONEXISTENT:

UNREACHABLE();

break;

@@ -1223,7 +1221,6 @@ void TransitionArray::PrintTransitions(FILE* out) {

case NORMAL:

case HANDLER:

case INTERCEPTOR:

- case TRANSITION:

case NONEXISTENT:

UNREACHABLE();

break;

« no previous file with comments | « src/objects-inl.h ('k') | src/property.h » ('j') | no next file with comments »