ui/base/clipboard/clipboard_android_unittest.cc - Issue 2231923002: Make GetApplicationContext return a JavaRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/clipboard/clipboard_android_unittest.cc

Issue 2231923002: Make GetApplicationContext return a JavaRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also fix not-currently-compiled unit test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/base/clipboard/clipboard_android_unittest.cc

diff --git a/ui/base/clipboard/clipboard_android_unittest.cc b/ui/base/clipboard/clipboard_android_unittest.cc

index b6744a2b36ef08daf69b9d29f323cb6c4a7ff264..d52013d4bcbe3bb9dac6a34450e025994956279c 100644

--- a/ui/base/clipboard/clipboard_android_unittest.cc

+++ b/ui/base/clipboard/clipboard_android_unittest.cc

@@ -44,9 +44,6 @@ TEST_F(ClipboardAndroidTest, InternalClipboardInvalidation) {

JNIEnv* env = base::android::AttachCurrentThread();

ASSERT_TRUE(env);

- jobject context = base::android::GetApplicationContext();

- ASSERT_TRUE(context);

Theresa 2016/08/15 17:54:14 Why is this check no longer necessary?

ScopedJavaLocalRef<jclass> context_class =

base::android::GetClass(env, "android/content/Context");

@@ -59,7 +56,8 @@ TEST_F(ClipboardAndroidTest, InternalClipboardInvalidation) {

ConvertUTF8ToJavaString(env, "clipboard");

ScopedJavaLocalRef<jobject> clipboard_manager(

env,

- env->CallObjectMethod(context, get_system_service, service_name.obj()));

+ env->CallObjectMethod(base::android::GetApplicationContext(),

+ get_system_service, service_name.obj()));

ASSERT_TRUE(clipboard_manager.obj() && !base::android::ClearException(env));

ScopedJavaLocalRef<jclass> clipboard_class =

« no previous file with comments | « ui/base/clipboard/clipboard_android.cc ('k') | ui/base/touch/touch_device_android.cc » ('j') | no next file with comments »