ui/base/clipboard/clipboard_android.cc - Issue 2231923002: Make GetApplicationContext return a JavaRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ui/base/clipboard/clipboard_android.cc

Issue 2231923002: Make GetApplicationContext return a JavaRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also fix not-currently-compiled unit test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ui/base/clipboard/clipboard_android.cc

diff --git a/ui/base/clipboard/clipboard_android.cc b/ui/base/clipboard/clipboard_android.cc

index de51d04aa1fc839f4dbf77d5683900e998926f76..6b010d6e45af89e60d9adb60817875f9198a00ee 100644

--- a/ui/base/clipboard/clipboard_android.cc

+++ b/ui/base/clipboard/clipboard_android.cc

@@ -64,14 +64,8 @@ class ClipboardMap {

base::LazyInstance<ClipboardMap>::Leaky g_map = LAZY_INSTANCE_INITIALIZER;

ClipboardMap::ClipboardMap() {

- JNIEnv* env = AttachCurrentThread();

- DCHECK(env);

- // Get the context.

- jobject context = base::android::GetApplicationContext();

- DCHECK(context);

- clipboard_manager_.Reset(Java_Clipboard_create(env, context));

+ clipboard_manager_.Reset(Java_Clipboard_create(

+ AttachCurrentThread(), base::android::GetApplicationContext()));

DCHECK(clipboard_manager_.obj());

}