media/base/android/media_player_android.h - Issue 2231923002: Make GetApplicationContext return a JavaRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/base/android/media_player_android.h

Issue 2231923002: Make GetApplicationContext return a JavaRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also fix not-currently-compiled unit test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: media/base/android/media_player_android.h

diff --git a/media/base/android/media_player_android.h b/media/base/android/media_player_android.h

index 57a9908f139f3036632998df9b6cf17c00b657a6..a6c5e0b7915c29acd415df618cbc073955bba60b 100644

--- a/media/base/android/media_player_android.h

+++ b/media/base/android/media_player_android.h

@@ -10,6 +10,7 @@

#include <memory>

#include <string>

+#include "base/android/scoped_java_ref.h"

#include "base/callback.h"

#include "base/macros.h"

#include "base/memory/weak_ptr.h"

@@ -128,7 +129,7 @@ class MEDIA_EXPORT MediaPlayerAndroid {

// Attach/Detaches |listener_| for listening to all the media events. If

// |j_media_player| is NULL, |listener_| only listens to the system media

// events. Otherwise, it also listens to the events from |j_media_player|.

- void AttachListener(jobject j_media_player);

+ void AttachListener(const base::android::JavaRef<jobject>& j_media_player);

void DetachListener();

protected: