components/invalidation/impl/invalidation_service_android.cc - Issue 2231923002: Make GetApplicationContext return a JavaRef.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/invalidation/impl/invalidation_service_android.cc

Issue 2231923002: Make GetApplicationContext return a JavaRef. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also fix not-currently-compiled unit test Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/invalidation/impl/invalidation_service_android.cc

diff --git a/components/invalidation/impl/invalidation_service_android.cc b/components/invalidation/impl/invalidation_service_android.cc

index c0704a56408c1b188d23c2437dececc6448cec7a..bc30b0fbad1929bdbe2d0e4ac154af224c69afb2 100644

--- a/components/invalidation/impl/invalidation_service_android.cc

+++ b/components/invalidation/impl/invalidation_service_android.cc

@@ -14,13 +14,14 @@

using base::android::ConvertJavaStringToUTF8;

using base::android::ConvertUTF8ToJavaString;

+using base::android::JavaRef;

using base::android::JavaParamRef;

namespace invalidation {

-InvalidationServiceAndroid::InvalidationServiceAndroid(jobject context)

- : invalidator_state_(syncer::INVALIDATIONS_ENABLED),

- logger_() {

+InvalidationServiceAndroid::InvalidationServiceAndroid(

+ const JavaRef<jobject>& context)

+ : invalidator_state_(syncer::INVALIDATIONS_ENABLED), logger_() {

DCHECK(CalledOnValidThread());

JNIEnv* env = base::android::AttachCurrentThread();

base::android::ScopedJavaLocalRef<jobject> local_java_ref =