Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(68)

Issue 2231913002: Register SwiftShader key without using chrome-internal header. (Closed)

Created:
4 years, 4 months ago by capn
Modified:
4 years, 4 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Register SwiftShader key without using chrome-internal header. //third_party/swiftshader/include/software_renderer.h from chrome-internal is used to register a secret license key to disable SwiftShader's legacy logo watermark in official Chrome builds. We're going to populate that directory with the full SwiftShader source code instead, since it is now open-source, but it adds Khronos headers which ozone is not compatible with (Issue 635702). Hence we need to avoid having anything depend on the old include directory content. The open-sourcing also means the the old license key does not need to be kept secret, so we can use it directly in chromium during the transition to logo-free builds. BUG=630728 Change-Id: Ica40e98a276fc5e1a48178cecb0d908d14482622 Committed: https://crrev.com/16a129d49fbd09f6a1f012845973d56d7d1f32f1 Cr-Commit-Position: refs/heads/master@{#411372}

Patch Set 1 #

Patch Set 2 : Also remove include paths #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -13 lines) Patch
M ui/gl/BUILD.gn View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gl/init/BUILD.gn View 1 1 chunk +0 lines, -4 lines 0 comments Download
M ui/gl/init/gl_initializer_win.cc View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 20 (14 generated)
capn
PTAL
4 years, 4 months ago (2016-08-11 17:43:57 UTC) #12
Ken Russell (switch to Gerrit)
Well if the cat wasn't out of the bag before, it sure is now! LGTM
4 years, 4 months ago (2016-08-11 17:52:20 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231913002/20001
4 years, 4 months ago (2016-08-11 17:54:29 UTC) #15
piman
lgtm
4 years, 4 months ago (2016-08-11 17:56:10 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-11 18:07:57 UTC) #18
commit-bot: I haz the power
4 years, 4 months ago (2016-08-11 18:11:41 UTC) #20
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/16a129d49fbd09f6a1f012845973d56d7d1f32f1
Cr-Commit-Position: refs/heads/master@{#411372}

Powered by Google App Engine
This is Rietveld 408576698