Add "exact" constraint evaluation to video picker.

Add "exact" constraint evaluation to video picker.

This lets the code accept constraints like:

video: { width: { exact: 1280 }}

with the same meaning as

video: { width: { min: 1280, max: 1280 }}

BUG=620665
Committed: https://crrev.com/03114092446268d86e2f6986a5c69a4ef6c9b11e
Cr-Commit-Position: refs/heads/master@{#411364}

[hta - Chromium, 2016-08-11 08:54:31]

Description was changed from

==========
Add "exact" constraint evaluation to video picker.

This lets the code accept constraints like:

video: { width: { exact: 1280 }}

with the same meaning as

video: { width: { min: 1280, max: 1280 }}

BUG=620665
==========

to

==========
Add "exact" constraint evaluation to video picker.

This lets the code accept constraints like:

video: { width: { exact: 1280 }}

with the same meaning as

video: { width: { min: 1280, max: 1280 }}

BUG=620665
==========

[hta - Chromium, 2016-08-11 08:54:31]

hta@chromium.org changed reviewers:
+ guidou@chromium.org, tommi@chromium.org

[hta - Chromium, 2016-08-11 08:54:40]

The CQ bit was checked by hta@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-11 08:54:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hta - Chromium, 2016-08-11 08:55:30]

Please take a look.
This code will change with Guido's work on reworking constraint evaluation, but
this fix makes it work for the bug reported (I think).

[Guido Urdaneta, 2016-08-11 09:25:01]

https://codereview.chromium.org/2231863004/diff/1/content/renderer/media/medi...
File content/renderer/media/media_stream_video_source.cc (right):

https://codereview.chromium.org/2231863004/diff/1/content/renderer/media/medi...
content/renderer/media/media_stream_video_source.cc:38: //
nit: is this empty line with "//" intentional

https://codereview.chromium.org/2231863004/diff/1/content/renderer/media/medi...
content/renderer/media/media_stream_video_source.cc:46:
basic_constraints.height.hasExact()) {
what if it has exact width and max height, but no exact height?

[commit-bot: I haz the power, 2016-08-11 10:19:44]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-11 10:19:44]

Dry run: This issue passed the CQ dry run.

[hta - Chromium, 2016-08-11 11:18:18]

Addressed Guido's comments, and found one bug and fixed it.
PTAL.

https://codereview.chromium.org/2231863004/diff/1/content/renderer/media/medi...
File content/renderer/media/media_stream_video_source.cc (right):

https://codereview.chromium.org/2231863004/diff/1/content/renderer/media/medi...
content/renderer/media/media_stream_video_source.cc:38: //
On 2016/08/11 09:25:01, Guido Urdaneta wrote:
> nit: is this empty line with "//" intentional

No. Removed.

https://codereview.chromium.org/2231863004/diff/1/content/renderer/media/medi...
content/renderer/media/media_stream_video_source.cc:46:
basic_constraints.height.hasExact()) {
On 2016/08/11 09:25:01, Guido Urdaneta wrote:
> what if it has exact width and max height, but no exact height?

That is a correct question to ask. I merged the two "if" blocks, with a comment
that exact constraints override max constraints.

[Guido Urdaneta, 2016-08-11 11:23:07]

lgtm

[tommi (sloooow) - chröme, 2016-08-11 15:31:59]

lgtm

[tommi (sloooow) - chröme, 2016-08-11 15:32:12]

The CQ bit was checked by tommi@chromium.org

[commit-bot: I haz the power, 2016-08-11 15:32:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-11 17:15:00]

Description was changed from

==========
Add "exact" constraint evaluation to video picker.

This lets the code accept constraints like:

video: { width: { exact: 1280 }}

with the same meaning as

video: { width: { min: 1280, max: 1280 }}

BUG=620665
==========

to

==========
Add "exact" constraint evaluation to video picker.

This lets the code accept constraints like:

video: { width: { exact: 1280 }}

with the same meaning as

video: { width: { min: 1280, max: 1280 }}

BUG=620665
==========

[commit-bot: I haz the power, 2016-08-11 17:15:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-08-11 17:16:52]

Description was changed from

==========
Add "exact" constraint evaluation to video picker.

This lets the code accept constraints like:

video: { width: { exact: 1280 }}

with the same meaning as

video: { width: { min: 1280, max: 1280 }}

BUG=620665
==========

to

==========
Add "exact" constraint evaluation to video picker.

This lets the code accept constraints like:

video: { width: { exact: 1280 }}

with the same meaning as

video: { width: { min: 1280, max: 1280 }}

BUG=620665

Committed: https://crrev.com/03114092446268d86e2f6986a5c69a4ef6c9b11e
Cr-Commit-Position: refs/heads/master@{#411364}
==========

[commit-bot: I haz the power, 2016-08-11 17:16:53]

Patchset 3 (id:??) landed as
https://crrev.com/03114092446268d86e2f6986a5c69a4ef6c9b11e
Cr-Commit-Position: refs/heads/master@{#411364}