Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(869)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: content/renderer/media/media_stream_constraints_util_unittest.cc

Issue 2231863004: Add "exact" constraint evaluation to video picker. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressing Guido's comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/media/media_stream_constraints_util.cc ('k') | content/renderer/media/media_stream_video_source.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/media/media_stream_constraints_util_unittest.cc
diff --git a/content/renderer/media/media_stream_constraints_util_unittest.cc b/content/renderer/media/media_stream_constraints_util_unittest.cc
index 5d71cbc54081d7e8fd76aa3bcd1f73a64a4b1cd1..786f681db4f2465c66b3cbc5e5a8e659bfedc697 100644
--- a/content/renderer/media/media_stream_constraints_util_unittest.cc
+++ b/content/renderer/media/media_stream_constraints_util_unittest.cc
@@ -89,6 +89,14 @@ TEST_F(MediaStreamConstraintsUtilTest, IntConstraints) {
EXPECT_TRUE(GetConstraintValueAsInteger(
constraints, &blink::WebMediaTrackConstraintSet::width, &value));
EXPECT_EQ(test_value, value);
+
+ // An exact value should also be reflected as min and max.
+ EXPECT_TRUE(GetConstraintMaxAsInteger(
+ constraints, &blink::WebMediaTrackConstraintSet::width, &value));
+ EXPECT_EQ(test_value, value);
+ EXPECT_TRUE(GetConstraintMinAsInteger(
+ constraints, &blink::WebMediaTrackConstraintSet::width, &value));
+ EXPECT_EQ(test_value, value);
}
} // namespace content
« no previous file with comments | « content/renderer/media/media_stream_constraints_util.cc ('k') | content/renderer/media/media_stream_video_source.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698