Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(295)

Issue 2231833002: Roll GN: gn format is --in-place by default (Closed)

Created:
4 years, 4 months ago by mtklein_C
Modified:
4 years, 4 months ago
Reviewers:
jcgregorio, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Roll GN: gn format is --in-place by default As usual, might as well roll, and this new behavior is a small convenience. BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2231833002 Committed: https://skia.googlesource.com/skia/+/d434b01c7e589b721c7969d7dfc6a25f99bdc23b

Patch Set 1 #

Patch Set 2 : add a link pool #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -4 lines) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M PRESUBMIT.py View 1 chunk +2 lines, -3 lines 0 comments Download
M gn/BUILD.gn View 1 3 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (11 generated)
mtklein_C
4 years, 4 months ago (2016-08-10 13:42:49 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231833002/1
4 years, 4 months ago (2016-08-10 13:42:51 UTC) #5
jcgregorio
lgtm
4 years, 4 months ago (2016-08-10 13:43:26 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot/builds/168) Build-Ubuntu-Clang-x86_64-Debug-GN-Trybot on master.client.skia.compile (JOB_FAILED, ...
4 years, 4 months ago (2016-08-10 13:46:01 UTC) #8
mtklein_C
Seems like the pool option on linking tools has switched from optional to seems-optional-really-required. I've ...
4 years, 4 months ago (2016-08-10 13:58:36 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231833002/20001
4 years, 4 months ago (2016-08-10 14:30:07 UTC) #16
commit-bot: I haz the power
4 years, 4 months ago (2016-08-10 14:31:01 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/d434b01c7e589b721c7969d7dfc6a25f99bdc23b

Powered by Google App Engine
This is Rietveld 408576698