Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: PRESUBMIT.py

Issue 2231833002: Roll GN: gn format is --in-place by default (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: add a link pool Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « DEPS ('k') | gn/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: PRESUBMIT.py
diff --git a/PRESUBMIT.py b/PRESUBMIT.py
index 95fea4f8dbfddd6054492980d9ccd4fa242d96b9..3fd8314f0b8074a82334481a0b753d777723c9e7 100644
--- a/PRESUBMIT.py
+++ b/PRESUBMIT.py
@@ -196,10 +196,9 @@ def _CheckGNFormatted(input_api, output_api):
try:
subprocess.check_output(cmd)
except subprocess.CalledProcessError:
- fix = cmd[:]
- fix[2] = '--in-place'
+ fix = 'gn format ' + f.LocalPath()
results.append(output_api.PresubmitError(
- '`%s` failed, try\n\t%s' % (' '.join(cmd), ' '.join(fix))))
+ '`%s` failed, try\n\t%s' % (' '.join(cmd), fix)))
return results
« no previous file with comments | « DEPS ('k') | gn/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698