Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(636)

Unified Diff: src/ast/variables.cc

Issue 2231813003: Make Variable::is_this always return the correct value (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/variables.h ('k') | src/compiler/ast-graph-builder.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ast/variables.cc
diff --git a/src/ast/variables.cc b/src/ast/variables.cc
index f80822d1a6622ff244253cfbfd8becc5122a2335..9856be7daaff907f159cde32558827caa10c5772 100644
--- a/src/ast/variables.cc
+++ b/src/ast/variables.cc
@@ -54,7 +54,7 @@ bool Variable::IsGlobalObjectProperty() const {
// activation frame.
return (IsDynamicVariableMode(mode_) ||
(IsDeclaredVariableMode(mode_) && !IsLexicalVariableMode(mode_))) &&
- scope_ != NULL && scope_->is_script_scope() && !is_this();
+ scope_ != NULL && scope_->is_script_scope();
}
@@ -62,7 +62,7 @@ bool Variable::IsStaticGlobalObjectProperty() const {
// Temporaries are never global, they must always be allocated in the
// activation frame.
return (IsDeclaredVariableMode(mode_) && !IsLexicalVariableMode(mode_)) &&
- scope_ != NULL && scope_->is_script_scope() && !is_this();
+ scope_ != NULL && scope_->is_script_scope();
}
« no previous file with comments | « src/ast/variables.h ('k') | src/compiler/ast-graph-builder.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698