Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2231673002:
Allow disabling code signature for ios_framework_bundle target. (Closed)
|
Created:
4 years, 4 months ago by sdefresne Modified:
4 years, 4 months ago Reviewers:
justincohen CC:
chromium-reviews, cbentzel+watch_chromium.org Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionAllow disabling code signature for ios_framework_bundle target.
BUG=None
NOTRY=true
Committed: https://crrev.com/7de09f5fa3dcb383e6797b363dd3707cac184657
Cr-Commit-Position: refs/heads/master@{#410974}
Patch Set 1 #Patch Set 2 : Fix fat build. #
Messages
Total messages: 26 (15 generated)
The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by sdefresne@chromium.org
sdefresne@chromium.org changed reviewers: + justincohen@chromium.org
The CQ bit was checked by justincohen@chromium.org
lgtm
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
The CQ bit was checked by sdefresne@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from justincohen@chromium.org Link to the patchset: https://codereview.chromium.org/2231673002/#ps20001 (title: "Fix fat build.")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by sdefresne@chromium.org
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== Allow disabling code signature for ios_framework_bundle target. BUG=None ========== to ========== Allow disabling code signature for ios_framework_bundle target. BUG=None NOTRY=true ==========
Setting NOTRY=true since this only affect iOS, will allow to unblock the downstream autoroller and the only failure was on a windows bot flake.
Setting NOTRY=true since this only affect iOS, will allow to unblock the downstream autoroller and the only failure was on a windows bot flake.
The CQ bit was unchecked by sdefresne@chromium.org
The CQ bit was checked by sdefresne@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Allow disabling code signature for ios_framework_bundle target. BUG=None NOTRY=true ========== to ========== Allow disabling code signature for ios_framework_bundle target. BUG=None NOTRY=true ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Allow disabling code signature for ios_framework_bundle target. BUG=None NOTRY=true ========== to ========== Allow disabling code signature for ios_framework_bundle target. BUG=None NOTRY=true Committed: https://crrev.com/7de09f5fa3dcb383e6797b363dd3707cac184657 Cr-Commit-Position: refs/heads/master@{#410974} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/7de09f5fa3dcb383e6797b363dd3707cac184657 Cr-Commit-Position: refs/heads/master@{#410974} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
