Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(137)

Unified Diff: build/config/ios/rules.gni

Issue 2231673002: Allow disabling code signature for ios_framework_bundle target. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix fat build. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/cronet/ios/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/config/ios/rules.gni
diff --git a/build/config/ios/rules.gni b/build/config/ios/rules.gni
index c670170ac4b7649c60721e6dae33863bee2d7512..0ffb9e9c600cd3c70c1e75cbb9acb0a6daedb5d0 100644
--- a/build/config/ios/rules.gni
+++ b/build/config/ios/rules.gni
@@ -835,6 +835,7 @@ template("ios_framework_bundle") {
"assert_no_deps",
"bundle_deps",
"data_deps",
+ "enable_code_signing",
"info_plist",
"info_plist_target",
"output_name",
@@ -984,6 +985,7 @@ template("ios_framework_bundle") {
"assert_no_deps",
"bundle_deps",
"data_deps",
+ "enable_code_signing",
"info_plist",
"info_plist_target",
"output_name",
@@ -1152,13 +1154,18 @@ template("ios_framework_bundle") {
_entitlements_path = invoker.entitlements_path
}
+ _ios_enable_code_signing = ios_enable_code_signing
+ if (defined(invoker.enable_code_signing)) {
+ _ios_enable_code_signing = invoker.enable_code_signing
+ }
+
code_signing_script = _code_signing_script_path
code_signing_sources = [
_entitlements_path,
"$_shared_library_dir/$_output_name",
]
code_signing_outputs = [ "$bundle_root_dir/$_output_name" ]
- if (ios_enable_code_signing) {
+ if (_ios_enable_code_signing) {
code_signing_outputs +=
[ "$bundle_root_dir/_CodeSignature/CodeResources" ]
}
@@ -1173,7 +1180,7 @@ template("ios_framework_bundle") {
rebase_path("$_shared_library_dir/$_output_name", root_build_dir),
rebase_path(bundle_root_dir, root_build_dir),
]
- if (!ios_enable_code_signing) {
+ if (!_ios_enable_code_signing) {
code_signing_args += [ "--disable-code-signature" ]
}
}
« no previous file with comments | « no previous file | components/cronet/ios/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698