Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Issue 2231533003: Remove unneeded base/stl_util.h includes in headers. (Closed)

Created:
4 years, 4 months ago by Lei Zhang
Modified:
4 years, 3 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, cbentzel+watch_chromium.org, dmazzoni+watch_chromium.org, Matt Giuca, aboxhall+watch_chromium.org, tfarina, jam, nektar+watch_chromium.org, yuzo+watch_chromium.org, cmumford, je_julie, darin-cc_chromium.org, sync-reviews_chromium.org, oshima+watch_chromium.org, dtseng+watch_chromium.org, chromium-apps-reviews_chromium.org, cc-bugs_chromium.org, jsbell+idb_chromium.org, gcasto+watchlist_chromium.org, davemoore+watch_chromium.org, vabr+watchlistpasswordmanager_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unneeded base/stl_util.h includes in headers. And a base/message_loop/message_loop.h include as well. Also fix lint issues. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_precise_blink_rel TBR=aboxhall@chromium.org,asanka@chromium.org,finnur@chromium.org,jochen@chromium.org Committed: https://crrev.com/cf9519facc35997d27fe524d9abb6de78c30e54f Cr-Commit-Position: refs/heads/master@{#415182}

Patch Set 1 #

Patch Set 2 : lint, fix build #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -22 lines) Patch
M base/containers/scoped_ptr_hash_map.h View 1 chunk +0 lines, -1 line 0 comments Download
M base/json/json_value_converter.h View 1 5 chunks +4 lines, -5 lines 0 comments Download
M cc/base/contiguous_container.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M cc/base/contiguous_container.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/settings/device_oauth2_token_service_delegate.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/extensions/api/image_writer_private/operation_manager.h View 1 2 chunks +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/app_list/search/launcher_search/launcher_search_provider.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/password_manager/core/browser/password_manager.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/api/sync_data.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M components/sync/engine_impl/cycle/status_controller.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M content/browser/accessibility/ax_tree_id_registry.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/indexed_db/indexed_db_observer_changes.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M extensions/browser/updater/request_queue_impl.h View 1 1 chunk +1 line, -1 line 0 comments Download
M net/url_request/url_request_job.h View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M ui/accessibility/ax_tree_serializer.h View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 31 (22 generated)
Lei Zhang
Please review the entire CL. I will TBR owners as needed afterwards.
4 years, 4 months ago (2016-08-09 22:25:31 UTC) #9
danakj
base and cc LGTM :)
4 years, 4 months ago (2016-08-09 22:29:02 UTC) #11
Sami
Yay, lgtm!
4 years, 4 months ago (2016-08-10 10:44:18 UTC) #14
vabr (Chromium)
components/password_manager/core/browser/password_manager.h LGTM, thank you for the clean-up.
4 years, 4 months ago (2016-08-10 10:52:13 UTC) #15
Lei Zhang
Adding additional OWNERS to TBR: aboxhall: content/browser/accessibility, ui/accessibility asanka: net finnur: extensions jochen: components/sync, content/browser/indexed_db
4 years, 3 months ago (2016-08-29 21:03:58 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2231533003/40001
4 years, 3 months ago (2016-08-30 04:26:06 UTC) #26
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 3 months ago (2016-08-30 05:51:23 UTC) #28
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/cf9519facc35997d27fe524d9abb6de78c30e54f Cr-Commit-Position: refs/heads/master@{#415182}
4 years, 3 months ago (2016-08-30 05:54:39 UTC) #30
Finnur
4 years, 3 months ago (2016-08-30 10:13:43 UTC) #31
Message was sent while issue was closed.
extensions LGTM

Powered by Google App Engine
This is Rietveld 408576698