Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3755)

Unified Diff: base/json/json_value_converter.h

Issue 2231533003: Remove unneeded base/stl_util.h includes in headers. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/containers/scoped_ptr_hash_map.h ('k') | cc/base/contiguous_container.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/json/json_value_converter.h
diff --git a/base/json/json_value_converter.h b/base/json/json_value_converter.h
index 4cca034f3320395127b9e7698b3f2b3cec416785..187c4c44db79dd81f8cfb9f2419a09412a1e316b 100644
--- a/base/json/json_value_converter.h
+++ b/base/json/json_value_converter.h
@@ -15,7 +15,6 @@
#include "base/logging.h"
#include "base/macros.h"
#include "base/memory/scoped_vector.h"
-#include "base/stl_util.h"
#include "base/strings/string16.h"
#include "base/strings/string_piece.h"
#include "base/values.h"
@@ -200,7 +199,7 @@ class ValueFieldConverter : public ValueConverter<FieldType> {
public:
typedef bool(*ConvertFunc)(const base::Value* value, FieldType* field);
- ValueFieldConverter(ConvertFunc convert_func)
+ explicit ValueFieldConverter(ConvertFunc convert_func)
: convert_func_(convert_func) {}
bool Convert(const base::Value& value, FieldType* field) const override {
@@ -218,7 +217,7 @@ class CustomFieldConverter : public ValueConverter<FieldType> {
public:
typedef bool(*ConvertFunc)(const StringPiece& value, FieldType* field);
- CustomFieldConverter(ConvertFunc convert_func)
+ explicit CustomFieldConverter(ConvertFunc convert_func)
: convert_func_(convert_func) {}
bool Convert(const base::Value& value, FieldType* field) const override {
@@ -322,7 +321,7 @@ class RepeatedCustomValueConverter
public:
typedef bool(*ConvertFunc)(const base::Value* value, NestedType* field);
- RepeatedCustomValueConverter(ConvertFunc convert_func)
+ explicit RepeatedCustomValueConverter(ConvertFunc convert_func)
: convert_func_(convert_func) {}
bool Convert(const base::Value& value,
@@ -491,7 +490,7 @@ class JSONValueConverter {
if (!value.GetAsDictionary(&dictionary_value))
return false;
- for(size_t i = 0; i < fields_.size(); ++i) {
+ for (size_t i = 0; i < fields_.size(); ++i) {
const internal::FieldConverterBase<StructType>* field_converter =
fields_[i];
const base::Value* field = NULL;
« no previous file with comments | « base/containers/scoped_ptr_hash_map.h ('k') | cc/base/contiguous_container.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698