Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-strict-dynamic.html

Issue 2231523002: Make ResourceFetcher return Resources with LoadError instead of nullptrs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase, resolve comment rewrap conflicts. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-strict-dynamic.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-strict-dynamic.html b/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-strict-dynamic.html
index 41654c3c8b28ee596b0b50722e1a7443cf70d321..81e21f8cf22a96402c805693d45bb722962b413a 100644
--- a/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-strict-dynamic.html
+++ b/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-strict-dynamic.html
@@ -19,7 +19,9 @@
document.addEventListener("securitypolicyviolation", function (e) {
blocked[e.lineNumber] = true;
});
-
+ </script>
+ <!-- Need to individually wrap test cases in script blocks. Violation reports triggered by document.write() calls while the parser is waiting on blocking scipts are missing line numbers. See: https://crbug.com/649085. -->
+ <script nonce="abcdefg">
async_test(function (t) {
var e = document.createElement('script');
e.src = generateURL("append");
@@ -32,7 +34,8 @@
e.onerror = t.unreached_func("Error should not be triggered.");
document.body.appendChild(e);
}, "Script injected via 'appendChild' is allowed with 'strict-dynamic'.");
-
+ </script>
+ <script nonce="abcdefg">
async_test(function (t) {
var e = document.createElement('script');
e.src = generateURL("append-async");
@@ -46,7 +49,8 @@
e.onerror = t.unreached_func("Error should not be triggered.");
document.body.appendChild(e);
}, "Async script injected via 'appendChild' is allowed with 'strict-dynamic'.");
-
+ </script>
+ <script nonce="abcdefg">
async_test(function (t) {
var e = document.createElement('script');
e.src = generateURL("append-defer");
@@ -60,28 +64,31 @@
e.onerror = t.unreached_func("Error should not be triggered.");
document.body.appendChild(e);
}, "Deferred script injected via 'appendChild' is allowed with 'strict-dynamic'.");
-
+ </script>
+ <script nonce="abcdefg">
async_test(function (t) {
document.write("<scr" + "ipt src='" + generateURL("write") + "'></scr" + "ipt>");
setTimeout(t.step_func_done(function () {
assert_equals(loaded[generateURL("write")], undefined);
- assert_true(blocked[65]);
+ assert_true(blocked[70]);
}), 1);
}, "Script injected via 'document.write' is not allowed with 'strict-dynamic'.");
-
+ </script>
+ <script nonce="abcdefg">
async_test(function (t) {
document.write("<scr" + "ipt defer src='" + generateURL("write-defer") + "'></scr" + "ipt>");
setTimeout(t.step_func_done(function () {
assert_equals(loaded[generateURL("write-defer")], undefined);
- assert_true(blocked[73]);
+ assert_true(blocked[79]);
}), 1);
}, "Deferred script injected via 'document.write' is not allowed with 'strict-dynamic'.");
-
+ </script>
+ <script nonce="abcdefg">
async_test(function (t) {
document.write("<scr" + "ipt async src='" + generateURL("write-async") + "'></scr" + "ipt>");
setTimeout(t.step_func_done(function () {
assert_equals(loaded[generateURL("write-async")], undefined);
- assert_true(blocked[81]);
+ assert_true(blocked[88]);
}), 1);
}, "Async script injected via 'document.write' is not allowed with 'strict-dynamic'.");
</script>
@@ -99,7 +106,8 @@
e.onerror = t.unreached_func("Error should not be triggered.");
document.body.appendChild(e);
}, "Script injected via deferred 'appendChild' is allowed with 'strict-dynamic'.");
-
+ </script>
+ <script nonce="abcdefg" defer>
async_test(function (t) {
var e = document.createElement('script');
e.src = generateURL("defer-append-async");
@@ -114,7 +122,8 @@
e.onerror = t.unreached_func("Error should not be triggered.");
document.body.appendChild(e);
}, "Async script injected via deferred 'appendChild' is allowed with 'strict-dynamic'.");
-
+ </script>
+ <script nonce="abcdefg" defer>
async_test(function (t) {
var e = document.createElement('script');
e.src = generateURL("defer-append-defer");
@@ -129,28 +138,31 @@
e.onerror = t.unreached_func("Error should not be triggered.");
document.body.appendChild(e);
}, "Deferred script injected via deferred 'appendChild' is allowed with 'strict-dynamic'.");
-
+ </script>
+ <script nonce="abcdefg" defer>
async_test(function (t) {
document.write("<scr" + "ipt src='" + generateURL("defer-write") + "'></scr" + "ipt>");
setTimeout(t.step_func_done(function () {
assert_equals(loaded[generateURL("defer-write")], undefined);
- assert_true(blocked[134]);
+ assert_true(blocked[144]);
}), 1);
}, "Script injected via deferred 'document.write' is not allowed with 'strict-dynamic'.");
-
+ </script>
+ <script nonce="abcdefg" defer>
async_test(function (t) {
document.write("<scr" + "ipt defer src='" + generateURL("defer-write-defer") + "'></scr" + "ipt>");
setTimeout(t.step_func_done(function () {
assert_equals(loaded[generateURL("defer-write-defer")], undefined);
- assert_true(blocked[142]);
+ assert_true(blocked[153]);
}), 1);
}, "Deferred script injected via deferred 'document.write' is not allowed with 'strict-dynamic'.");
-
+ </script>
+ <script nonce="abcdefg" defer>
async_test(function (t) {
document.write("<scr" + "ipt async src='" + generateURL("defer-write-async") + "'></scr" + "ipt>");
setTimeout(t.step_func_done(function () {
assert_equals(loaded[generateURL("defer-write-async")], undefined);
- assert_true(blocked[150]);
+ assert_true(blocked[162]);
}), 1);
}, "Async script injected via deferred 'document.write' is not allowed with 'strict-dynamic'.");
</script>

Powered by Google App Engine
This is Rietveld 408576698