Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-whitelist.html

Issue 2231523002: Make ResourceFetcher return Resources with LoadError instead of nullptrs. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase, resolve comment rewrap conflicts. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-whitelist.html
diff --git a/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-whitelist.html b/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-whitelist.html
index 16eccc1833297e0dd18a8efdd5da3635a85a6b93..6b441c29313069069f3a646b4a1d4ff848206f77 100644
--- a/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-whitelist.html
+++ b/third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/script-src-strict-dynamic-whitelist.html
@@ -19,28 +19,32 @@
document.addEventListener("securitypolicyviolation", function (e) {
blocked[e.lineNumber] = true;
});
-
+ </script>
+ <!-- Need to individually wrap test cases in script blocks. Violation reports triggered by document.write() calls while the parser is waiting on blocking scipts are missing line numbers. See: https://crbug.com/649085. -->
+ <script nonce="abcdefg">
async_test(function (t) {
document.write("<scr" + "ipt src='" + generateURL("write") + "'></scr" + "ipt>");
setTimeout(t.step_func_done(function () {
assert_equals(loaded[generateURL("write")], undefined);
- assert_true(blocked[24]);
+ assert_true(blocked[26]);
}), 1);
}, "Script injected via 'document.write' is not allowed with 'strict-dynamic', even if whitelisted.");
-
+ </script>
+ <script nonce="abcdefg">
async_test(function (t) {
document.write("<scr" + "ipt defer src='" + generateURL("write-defer") + "'></scr" + "ipt>");
setTimeout(t.step_func_done(function () {
assert_equals(loaded[generateURL("write-defer")], undefined);
- assert_true(blocked[32]);
+ assert_true(blocked[35]);
}), 1);
}, "Deferred script injected via 'document.write' is not allowed with 'strict-dynamic', even if whitelisted.");
-
+ </script>
+ <script nonce="abcdefg">
async_test(function (t) {
document.write("<scr" + "ipt async src='" + generateURL("write-async") + "'></scr" + "ipt>");
setTimeout(t.step_func_done(function () {
assert_equals(loaded[generateURL("write-async")], undefined);
- assert_true(blocked[40]);
+ assert_true(blocked[44]);
}), 1);
}, "Async script injected via 'document.write' is not allowed with 'strict-dynamic', even if whitelisted.");
</script>

Powered by Google App Engine
This is Rietveld 408576698