Issue 2231413003: Link packages with an SDK extension.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2231413003: Link packages with an SDK extension. (Closed)

Created:
4 years, 4 months ago by scheglov

Modified:
4 years, 4 months ago

Reviewers:
Paul Berry, Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Link packages with an SDK extension. R=brianwilkerson@google.com, paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/e1fd213d552b1f59ecf05d6296393318fcbb0760

Patch Set 1 #

Total comments: 1

Created: 4 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+72 lines, -2 lines)			Patch
	M	pkg/analyzer/lib/src/summary/pub_summary.dart	View		2 chunks	+9 lines, -2 lines	1 comment	Download
	M	pkg/analyzer/test/src/summary/pub_summary_test.dart	View		1 chunk	+63 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

scheglov

Committed patchset #1 (id:1) manually as e1fd213d552b1f59ecf05d6296393318fcbb0760 (presubmit successful).

4 years, 4 months ago (2016-08-11 19:43:52 UTC) #4

Paul Berry

4 years, 4 months ago (2016-08-11 20:47:17 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/2231413003/diff/1/pkg/analyzer/lib/src/summar...
File pkg/analyzer/lib/src/summary/pub_summary.dart (right):

https://codereview.chromium.org/2231413003/diff/1/pkg/analyzer/lib/src/summar...
pkg/analyzer/lib/src/summary/pub_summary.dart:539: // The SDK linked bundle is
precomputed before linking packages.
(As discussed in person) I think we still need to include the SDK bundle (and
the SDK extension bundle, if it's referenced) so that the right data gets
encoded in PackageBundle.dependencies.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages