Link packages with an SDK extension.

pkg/analyzer/lib/src/summary/pub_summary.dart

 // Copyright (c) 2016, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 import 'dart:async';
 import 'dart:collection';
 import 'dart:core' hide Resource;
 
 import 'package:analyzer/dart/ast/ast.dart';
 import 'package:analyzer/dart/ast/token.dart';
@@ skipping 225 matching lines @@
 
     // Create graph nodes for packages.
     List<_LinkedNode> nodes = <_LinkedNode>[];
     Map<String, _LinkedNode> packageToNode = <String, _LinkedNode>{};
     unlinkedBundles.forEach((package, unlinked) {
       _LinkedNode node = new _LinkedNode(package, unlinked, packageToNode);
       nodes.add(node);
       packageToNode[package.name] = node;
     });
 
-    // Fill the store with unlinked bundles.
+    // Fill the store with the linked SDK and unlinked package bundles.
     SummaryDataStore store = new SummaryDataStore(const <String>[]);
     store.addBundle(null, sdkBundle);
+    {
+      PackageBundle extension = computeSdkExtension(context, sdkBundle);
+      if (extension != null) {
+        store.addBundle(null, extension);
+      }
+    }
     for (PackageBundle unlinked in unlinkedBundles.values) {
       store.addBundle(null, unlinked);
     }
 
     // Link each package node.
     for (_LinkedNode node in nodes) {
       if (!node.isEvaluated) {
         bool strong = context.analysisOptions.strongMode;
         new _LinkedWalker(store, strong).walk(node);
       }
@@ skipping 263 matching lines @@
   @override
   List<_LinkedNode> computeDependencies() {
     Set<_LinkedNode> dependencies = new Set<_LinkedNode>();
     for (UnlinkedUnit unit in unlinked.unlinkedUnits) {
       for (UnlinkedImport import in unit.imports) {
         String uriStr = import.isImplicit ? 'dart:core' : import.uri;
         Uri uri = FastUri.parse(uriStr);
         if (!uri.hasScheme) {
           // A relative path in this package, skip it.
         } else if (uri.scheme == 'dart') {
-          // TODO(scheglov) link _sdkext bundles.
+          // Dependency on the SDK is implicit and always added.
+          // The SDK linked bundle is precomputed before linking packages.

[Paul Berry, 2016/08/11 20:47:17]

(As discussed in person) I think we still need to include the SDK bundle (and
the SDK extension bundle, if it's referenced) so that the right data gets
encoded in PackageBundle.dependencies.

         } else if (uriStr.startsWith('package:')) {
           String package = PubSummaryManager.getPackageName(uriStr);
           _LinkedNode packageNode = packageToNode[package];
           if (packageNode == null) {
             failed = true;
             return const <_LinkedNode>[];
           }
           dependencies.add(packageNode);
         } else {
           failed = true;
@@ skipping 57 matching lines @@
           }
         });
         node.linkedBuilder = assembler.assemble();
         store.addBundle(null, node.linkedBuilder);
       }
     } else {
       scc.forEach((node) => node.failed = true);
     }
   }
 }