A few fixes for image search:

A few fixes for image search:

* Name the command IDC_CONTENT_CONTEXT_SEARCHWEBFORIMAGE to be more parallel to
  the existing "...SEARCHWEBFOR" command and to avoid saying NEWTAB in the
  command name (since the command isn't inherently about new tabs).
* Clean up and fix comment on an exclusion for chrome UI scheme images.
* Fix erroneous DCHECK of default search provider when handling the ACK from the
  renderer; the search provider can go away while the IPC is in progress.  Also
  clean this code up a little.

BUG=none
TEST=none
R=jnd@chromium.org, sky@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=215919

[Peter Kasting, 2013-08-06 02:00:28]

jnd: Review
sky: OWNERS

[Avi (use Gerrit), 2013-08-06 02:29:41]

https://codereview.chromium.org/22314006/diff/1/chrome/browser/tab_contents/r...
File chrome/browser/tab_contents/render_view_context_menu.cc (right):

https://codereview.chromium.org/22314006/diff/1/chrome/browser/tab_contents/r...
chrome/browser/tab_contents/render_view_context_menu.cc:1279: // searched for
conventionally.
crbug.com/2608 which was referenced earlier seems to imply that this was a hack.
Is this now permanent?

[sky, 2013-08-06 14:16:29]

LGTM

[Johnny(Jianning) Ding, 2013-08-06 16:54:57]

On 2013/08/06 14:16:29, sky wrote:
> LGTM

lgtm

[Peter Kasting, 2013-08-06 17:24:31]

https://codereview.chromium.org/22314006/diff/1/chrome/browser/tab_contents/r...
File chrome/browser/tab_contents/render_view_context_menu.cc (right):

https://codereview.chromium.org/22314006/diff/1/chrome/browser/tab_contents/r...
chrome/browser/tab_contents/render_view_context_menu.cc:1279: // searched for
conventionally.
On 2013/08/06 02:29:41, Avi wrote:
> crbug.com/2608 which was referenced earlier seems to imply that this was a
hack.
> Is this now permanent?

Yes, and I'm OK with that.

Sid is no longer on the team, and he marked the bug fixed when he checked in his
original quick fix, so no one has ever looked at doing a followup.

I tried to do things like right-click NTP images to get image context menu
options, but since they all use CSS background-image or other tricks that
prevent Chrome from showing image context menu options anyway, it seems
impossible to even try to trigger this.  If you dig deeply into the inspector
and fiddle until you get something clickable, the URL is just some chrome
internal scheme thing, and the resulting image isn't something there's really a
use case for trying to e.g. search for.  So I think it's fine to just nix the
TODO.  If someone someday comes up with a compelling use case and UI for doing
more here, they can always implement more functionality then.

[Peter Kasting, 2013-08-06 17:24:52]

Committed patchset #1 manually as r215919 (presubmit successful).